Closed Bug 1991755 Opened 1 year ago Closed 1 year ago

Account Hub: Fix border radius on text inputs

Categories

(Thunderbird :: Account Manager, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED
145 Branch

People

(Reporter: vineet, Assigned: vineet)

References

(Blocks 2 open bugs)

Details

(Keywords: regression)

Attachments

(1 external file)

Common.css was updated to have an 8px border radius, which changed how account hub text inputs look compared to the design. The design has a 3px border radius on text inputs, so this patch fixes that issue.

Summary: Account Hub Email: Fix border radius on text inputs → Account Hub: Fix border radius on text inputs

Hmm, so why is common.css changing and account hub not? I mean, doesn't this mean inconsistency for the account hub vs. elsewhere?

Severity: -- → S4

(In reply to Magnus Melin [:mkmelin] from comment #2)

Hmm, so why is common.css changing and account hub not? I mean, doesn't this mean inconsistency for the account hub vs. elsewhere?

Seems that a lot of places using input have defined their border-radius with the value in this patch (eg preferences, searchbar). The inputs in accountHub were using the common.css value before, and it looked like the right value, until the change to common.css. So we have to update the accountHub css to make sure that the border-radius is correct.

Target Milestone: --- → 145 Branch

Pushed by vineet@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/5dc9a6d36e1e
Account Hub: Fix border radius on text inputs. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: