1992446 - Upgrade Firefox 146 to NSS 3.118

Status: RESOLVED FIXED

(Core :: Security: PSM, task, P1)

Comment 1

[Dennis Jackson]

Attachment: Bug 1992446 - upgrade NSS to f9041cc46f7495257b639e7e36fa8f2f0d50faa0. r=#nss-reviewers UPGRADE_NSS_RELEASE

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/983a0a54341c
https://hg.mozilla.org/integration/autoland/rev/8f48c9d1d308
upgrade NSS to f9041cc46f7495257b639e7e36fa8f2f0d50faa0. r=nss-reviewers,jschanck UPGRADE_NSS_RELEASE

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8f48c9d1d308

Comment 4

[Anna Weine]

Attachment: Bug 1992446 - upgrade NSS to 18dcc6d128e0b6f2acc3276e81669ec5870b713e. r=#nss-reviewers UPGRADE_NSS_RELEASE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7279cec1892b
https://hg.mozilla.org/integration/autoland/rev/d37569de272b
upgrade NSS to 18dcc6d128e0b6f2acc3276e81669ec5870b713e. r=nss-reviewers,jschanck UPGRADE_NSS_RELEASE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0b0db692d859
https://hg.mozilla.org/integration/autoland/rev/a34ae3d47c6b
Revert "Bug 1992446 - upgrade NSS to 18dcc6d128e0b6f2acc3276e81669ec5870b713e. r=nss-reviewers,jschanck UPGRADE_NSS_RELEASE" for causing WPT failures @ ec_importKey.https.any.worker.html

Comment 8

[pstanciu]

Backed out for causing WPT failures @ ec_importKey.https.any.worker.html

• https://hg.mozilla.org/integration/autoland/rev/a34ae3d47c6b4bb89db049ee2e2caeb500aeec92
• Push with failures
• Failure Log

Comment 9

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/a34ae3d47c6b

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d37569de272b

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/415ea8686f4a
https://hg.mozilla.org/integration/autoland/rev/5674b3ee99d0
upgrade NSS to 18dcc6d128e0b6f2acc3276e81669ec5870b713e. r=nss-reviewers,jschanck UPGRADE_NSS_RELEASE

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5674b3ee99d0

Comment 14

[Landry Breuil (:gaston)]

can we pretty please get an actual release/source tarball of NSS 3.118 pushed to the mirrors for packagers/downstreams ? as it is now, it's impossible to build 146b1 using --with-system-nss. I know there's been last-minutes shenanigans with nspr 4.38.2 but still would be good to be sorted out :)

thanks !

Comment 15

[tt_1]

this last minute fix was essential for building firefox-146_beta against nss-3.118:
https://github.com/nss-dev/nss/commit/6e546d91dc9a4029a7812fcd842272598b5defc0

the delay is propably due to that

but 146 is on beta4 now, so please push nss-3.118 tarballs as soon they are available

Comment 16

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1992446 - Upgrade Firefox 146 to NSS 3.118 r=#nss-reviewers UPGRADE_NSS_RELEASE

Comment 17

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1992446 - Upgrade Firefox 146 to NSS 3.118 RTM r=#nss-reviewers UPGRADE_NSS_RELEASE

Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No (no functional changes)
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: String change, no functional change
[String changes made/needed]: No additional need

The following patch is the only one needing an uplift (others are in 146 already)
This change is a simple removal of the beta string for NSS to have an RTM instead.
https://phabricator.services.mozilla.com/D273008

Comment 18

[Benjamin Beurdouche [:beurdouche]]

Status update.
We will be releasing :

• NSS 3.118.0 for Firefox 146 (this will not build with --with-system-nss)
• NSS 3.118.1 so that users of --with-system-nss can build 146 by packaging with that version

On the next release :

• NSS 3.119.0 will have the NSPR 4.38.2 update

Comment 19

[Landry Breuil (:gaston)]

thanks, 3.118.1 builds fine, will test 146.0b5 against it.

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/599556e746d4
https://hg.mozilla.org/releases/mozilla-beta/rev/33da7c7f7899

Comment 21

[Benjamin Beurdouche [:beurdouche]]

Thanks Dianna !