1992740 - [composable toolbar] Toolbar keeps disconnecting from bottom of screen

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Paul [pwd]]

Attachment: Screenshot_20251006-152620_1.png

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:145.0) Gecko/145.0 Firefox/145.0

Steps to reproduce:

1. Open a site that requires a login
2. Login using a password manager

Actual results:

When the site logs in, the gap where the keyboard was remains

Expected results:

The gap should close.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Hello,
Thank you for the report!
In some quick tests I cannot reproduce.
I see you marked this with the [composable toolbar] tag. Does the issue not reproduce for you with the "composable toolbar" disabled from secret settings?
Does the gap close if you interact with the webpage?
Can you also share on what device you are seeing the issue (seems like you're using Android 16 but I'm curious of the model also)?
Asking QA to also check if this can be consistently reproduced.

Comment 2

[Paul [pwd]]

Can I just start out by saying that I appreciate you so much Petru. You're actually amazing!

I can reproduce this consistently and it's only with the new composable toolbar. On both Heimdall (self hosted dashboard) and Pi-Hole.

Yes the gap closes upon interaction with the website.

I can also reproduce this on both my Android 16 devices, Pixel 8 Pro and Pixel 6 Pro

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Thank you!

Comment 4

[Petru-Mugurel Lingurar [:petru]]

May I also ask about what keyboard you're using?
The "gap" seen in your screenshot seems smaller than most keyboard's heights and since we react to the keyboard state it might be that we have an incompatibility with a particular less popular one.

Comment 5

[Paul [pwd]]

Gboard Beta. My theory is that an animation starts and doesn't finish for some reason.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Thank you!
This is really interesting.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Can confirm something did change in the Android callbacks we get for the keyboard state.
Looking for a workaround.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1992740 - Ensure keyboard insets are applied when keyboard closes r=#android-reviewers

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Cannot reproduce but I think I identified the issue.
Seems like a remainder of bug 1991459.

If it's okay with you Paul I'll ask for a confirmation of the fix once we have a build from our CI servers.

Comment 10

[Paul [pwd]]

Of course, always happy to help when I can

Comment 11

[Petru-Mugurel Lingurar [:petru]]

(In reply to Paul [pwd] from comment #10)

Of course, always happy to help when I can

Sorry but I still cannot reproduce this to confidently validate the fix.
Also note that we are now preparing for a new release so there is not a rush to test this as we cannot land more patches this week.

When you have the time can you sideload target.arm64-v8a.apk from here to test if the issues seems fixed?
(that is an APK built for internal testing and contains the same code as Nightly + the change from the patch attached to this ticket. It will not conflict with your other Firefox installs and can be uninstalled after the tests as it will not receive any automated updates)

Thank you!

Comment 12

[Paul [pwd]]

Using the debug build I'm unable to reproduce. The keyboard seems to dismiss on submit press/before the page load.

Comment 13

[Petru-Mugurel Lingurar [:petru]]

That's great to hear, thank you!
Will try to include the fix in next Nightly v.146.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58c3eb48f98a
https://hg.mozilla.org/integration/autoland/rev/1d193c8fb5f4
Ensure keyboard insets are applied when keyboard closes r=android-reviewers,skhan

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1d193c8fb5f4

Comment 16

[Petru-Mugurel Lingurar [:petru]]

@QA Can you verify that the issue described here and/or the one from are now fixed?

Comment 17

[Paul [pwd]]

Obviously not QA, but can confirm I'm no longer seeing the problem in 2025-10-14T09:55:35 whereas I was still seeing it in yesterday's build.

Comment 18

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox for Android Nightly 146.0a1 from 10/14 using a Pixel 6 (Android 16), and Samsung Galaxy S24 (Android 15).
I have to mention I only encountered this issue once on the Pixel device, before the fix.

Comment 19

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: The bottom toolbar may not be properly attached to the screen bottom or on top of the keyboard.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Verify the scenarios from bug 1992740 and bug 1993668.
• Risk associated with taking this patch: low
• Explanation of risk level: Small targeted change verified by QA.
• String changes made/needed: --
• Is Android affected?: yes

Comment 20

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1992740 - Ensure keyboard insets are applied when keyboard closes r=#android-reviewers

Original Revision: https://phabricator.services.mozilla.com/D268115

Comment 21

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: The bottom toolbar may not be properly attached to the screen bottom or on top of the keyboard.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Verify the scenarios from bug 1992740 and bug 1993668.
• Risk associated with taking this patch: low
• Explanation of risk level: Small targeted change verified by QA.
• String changes made/needed: --
• Is Android affected?: yes

Comment 22

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1992740 - Ensure keyboard insets are applied when keyboard closes r=#android-reviewers

Original Revision: https://phabricator.services.mozilla.com/D268115

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d76c04a67e79
https://hg.mozilla.org/releases/mozilla-beta/rev/24383de1e1db

Comment 24

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/828eaddb5b09
https://hg.mozilla.org/releases/mozilla-release/rev/0da3beccf698

Comment 26

[Lorand Janos]

Verified the scenarios from bug 1992740 and bug 1993668 on the latest Firefox for Android Beta 145.0b3 using a Pixel 7 (Android 16), and Samsung Galaxy S23 Ultra (Android 15).

Marking the ticket as verified on 145.

Comment 28

[Lorand Janos]

Attachment: Edited_20251021_085444.mp4

Verified the same scenarios as for Beta, from bug 1992740 and bug 1993668 on the latest Firefox for Android 144.0.1 using a Pixel 7 (Android 16), and Samsung Galaxy S23 Ultra (Android 15).

Marking the ticket as verified on 144 as well.