199296 - bookmarks in overflow menu on personal toolbar don't work

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[j]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4a) Gecko/20030326
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4a) Gecko/20030326

In the latest nightly (20032604), bookmarks that are added to the new personal
toolbar overflow drop down menu do not work. 

Reproducible: Always

Steps to Reproduce:
1.use recent nightly with new personal toolbar overflow
2.resize browser until overflow arrow appears 
3.select a bookmark from the overflow menu

Actual Results:  
nothing

Expected Results:  
clicking on bookmark should go to specific bookmark url.

Comment 1

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4a) Gecko/20030326
I don´t need to resize my browser, i´ve got huge folders in the personal toolbar
 ;-)

opening works for me, 
I can scroll up and down in any folder on my personal toolbar, and the position
is remembered, so when opening again I´m at the position the folder has been closed.

adding works partly,
when dragging a bookmark to a folder in the Personal Toolbar,
that folder opens at the last scrolled to position, and I can add the bookmark
in the visible area. I can´t however scroll up or down to shift the visible area.

Comment 2

[Andreas Kunz]

Confirming (2003032612/CVS on Win2k) and cc'ing shliang who made that cool
overflow dropdown thing.

Comment 3

[shliang]

jag was the one who did the overflow thingy (bug 66919)

Comment 4

[sairuh (rarely reading bugmail)]

see my comments in bug 66919.

Comment 5

[Hermann Schwab]

Confirming: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4a) Gecko/20030326

My previous posting is correct, but description of another bug.
Now I´ve got grippies at the left and chevrons at the right of my Personal
Toolbar, and the rightmost folder is invisible, but shows up as overflow folder,
when I click on the chevrons. I can navigate in this folder, subfolder open,
bookmarks get selected, and if I click on a bookmark, all folders close,
but no action follows, nothing is loaded, browser windows is unchanged.
SO this folder is accessible for getting bookmarks, but not working.
This folder isn´t accessible for storing bookmarks by dragging.
If I drag to the chevron, nothing opens.
If the folder is open, and I try to drag the bookmark from the Loacation Bar,
the folder closes.

Comment 6

[Andreas Kunz]

shliang, sorry; you only checked it in...
Well, as opposed to sairuh in bug 66919, the dropdown popup looks fine here in
both classic and modern on Win2k (but does not work).

Comment 7

[shliang]

Attachment: i don't think this line is supposed to be here

Comment 8

[Jan Varga [:janv]]

Comment on attachment 118567 [details] [diff] [review]
i don't think this line is supposed to be here

r=varga
I remember Jag mentioned to me that it works only for "current". Maybe he plans
to support other targets, but I can't find the getBroserTargetFromEvent()
anywhere.

Comment 9

[jag (Peter Annema)]

Comment on attachment 118567 [details] [diff] [review]
i don't think this line is supposed to be here

Not yet. I'll leave that to the bookmarks heroes :-)

sr=jag

Comment 10

[jag (Peter Annema)]

Checked in.

Comment 11

[Chris Petersen]

Verified on the 2003-04-22-08 Macho and Win32 trunk builds.