1993031 - Create section for Firefox VPN in about:settings

Status: RESOLVED FIXED

(Firefox :: IP Protection, task, P1)

Description

[Becca]

Attachment: FirefoxVPNSettings.png

We need to create a Firefox VPN section in about:settings and add the header, description, and Learn More link. We are still waiting on feedback from UX as to where this section should sit within about:settings.

The VPN settings section should be controlled by a new pref, for example browser.ipProtection.settings.ui.enabled. This should control whether or not the entire section is displayed to the user.

To create the section, we need to add a dataIPProtectionGroup to preferences/privacy.inc.xhtml that includes the section, as well as the header (with description and learn more link).

Comment 1

[Becca]

Update: This section should go in about:settings#privacy after Website Privacy Preferences.

Comment 2

[Becca]

Attachment: Bug 1993031 - Create section for Firefox VPN in about:settings - r=#ip-protection-reviewers!

Comment 3

[Becca]

I chose to base the hidden property for the Firefox VPN section on the existing browser.ipProtection.variant pref rather than creating a new pref, but otherwise followed the described logic above. Also filed a follow-up (Bug 1993358) to handle updating the 'Learn more' link once we have the correct article to link to.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/553d79eebb10
https://hg.mozilla.org/integration/autoland/rev/57c03eacb203
Create section for Firefox VPN in about:settings - r=ip-protection-reviewers,fluent-reviewers,bolsson,mstriemer,fchasen

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/57c03eacb203