1993056 - Don't maintain two versions of the non-native theme colors

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1993056 - Don't maintain two versions of brand colors. r=dao!,mstriemer!

Instead special-case the built-in light and dark themes to reuse
browser-colors.

Use a built-in media query (-moz-native-theme), since otherwise checking
for it becomes quite annoying. If we didn't have the native-theme pref,
we could use an attribute selector perhaps, but this seems simpler.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1993056 - Revert bug 1971143 since now we don't get much benefit from this set-up. r=#theme!

Comment 3

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b91bba105634a7b2b147f6ae29c8d55e3cb9e44b, fwiw.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1993056 - Move light/dark theme config to BuiltInThemeConfig. r=#theme

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Magnus, I don't think this immediately affects Thunderbird, but you might want to use a similar set-up.

Comment 6

[Magnus Melin [:mkmelin]]

Thanks! Filed bug 1993309.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/87357ece4212
https://hg.mozilla.org/integration/autoland/rev/623f1b8fdfc2
Don't maintain two versions of brand colors. r=dao,desktop-theme-reviewers,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/f98572c5fa76
https://hg.mozilla.org/integration/autoland/rev/d9d2cef18434
Revert bug 1971143 since now we don't get much benefit from this set-up. r=desktop-theme-reviewers,dao
https://github.com/mozilla-firefox/firefox/commit/6273b2348e51
https://hg.mozilla.org/integration/autoland/rev/934fe5237f06
Move light/dark theme config to BuiltInThemeConfig. r=desktop-theme-reviewers,dao

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/623f1b8fdfc2
https://hg.mozilla.org/mozilla-central/rev/d9d2cef18434
https://hg.mozilla.org/mozilla-central/rev/934fe5237f06

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4e6ba75d99dd
https://hg.mozilla.org/releases/mozilla-beta/rev/107329c538f8
Revert "Bug 1993056 - Move light/dark theme config to BuiltInThemeConfig. r=desktop-theme-reviewers,dao" as requested by emilio.