Closed Bug 1993571 Opened 7 months ago Closed 6 months ago

Standalone setting-group is not hidden if all of its settings are hidden

Categories

(Firefox :: Settings UI, defect, P2)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
147 Branch
Tracking Flags:
Tracking Status
firefox147 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer)

References

Details

(Whiteboard: [recomp])

Attachments

(1 file)

Bug 1993571 - Hide a standalone setting-group if it has no visible settings r?#settings-reviewers
48 bytes, text/x-phabricator-request
Details | Review

When there's a standalone setting-group with all of its settings hidden the fieldset is still showing since the hidden attribute is being managed by the data-category searching code and causing it to be un-hidden.

We'll likely want some setting-groups that provide their own headings soon and therefore won't require a groupbox.

Severity: -- → S4
Summary: Standalong setting-group is not hidden if all of its settings are hidden → Standalone setting-group is not hidden if all of its settings are hidden
Blocks: 1994888
Depends on: 1984122
Assignee: nobody → tgiles
Status: NEW → ASSIGNED
Attachment #9519377 - Attachment description: WIP: Bug 1993571 - Hide a standalone setting-group if it has no visible settings r?#settings-reviewers → Bug 1993571 - Hide a standalone setting-group if it has no visible settings r?#settings-reviewers
Assignee: tgiles → mstriemer

https://hg.mozilla.org/mozilla-central/rev/dd9e4c525395

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox147: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
QA Whiteboard: [qa-triage-done-c148/b147]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: