1994009 - Clean the URLs before having them pasted when handling toolbar input in a composable

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Mimic the current functionality of stripping out unwanted schemes when content is pasted from clipboard while searching.
This can be done by passing in our own implementation of TextToolbar through CompositionLocal so that it will then be used for presenting the tet related options when the current input is long clicked.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1994009 - Sanitize the pasted text in the composable toolbar input r=#android-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fd8a661551ed
https://hg.mozilla.org/integration/autoland/rev/4d34d2b35f4b
Sanitize the pasted text in the composable toolbar input r=android-reviewers,skhan

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4d34d2b35f4b

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1994009 - Sanitize the pasted text in the composable toolbar input

Original Revision: https://phabricator.services.mozilla.com/D270204

(cherry picked from commit fd8a661551ed398326127643e54275adb89710fe)

Comment 5

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: With the staged rollout experiment making the new toolbar available to more people in Release these patches would be needed to avoid the issue from https://bugzilla.mozilla.org/show_bug.cgi?id=1980777
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=1980777#c0
  https://bugzilla.mozilla.org/show_bug.cgi?id=1980777#c7
• Risk associated with taking this patch: medium
• Explanation of risk level: It's a big change but available in Nightly for 20 days now and then in 146 beta with a single regression reported - https://bugzilla.mozilla.org/show_bug.cgi?id=1999177 - which might be expected behaviour.
• String changes made/needed: --
• Is Android affected?: yes

Comment 6

[Adina Petridean QA [:apetridean]]

Attachment: screen-20251119-144832.mp4

Verified as fixed on the latest Nightly 147.0a1 from 11/18 using a Samsung Galaxy S9 (Android 8), and a Pixel 10 (Android 16).

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a6abee7f4180
https://hg.mozilla.org/releases/mozilla-release/rev/adbbeedf7471

Comment 8

[Adina Petridean QA [:apetridean]]

Verified as fixed on RC 145.0.2 using a Samsung Tab S8 Ultra 5G (Android 15), and Google Pixel 3 XL (Android 9).