1999177 - Cannot scroll through URL bar using caret

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Jake Archibald [:jakea]]

Attachment: Demo

This appears to be a regression, as it doesn't happen in stable.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: SwipeToScrollLongUrl.mp4

The new behaviour is the one that we get from upstream, by integrating the BasicTextField from Jetpack Compose.
Agree this is a loss in control over interacting with the url.
Opened https://issuetracker.google.com/issues/459087295 @ Google for getting an official response/workaround/fix.

An important note is that the behavior is not fully broken, users can still swipe the text to get to the very end/beginning of it. As such I'll mark this as an S3.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1994013

Comment 3

[Aaron Train [:aaronmt]]

Seen on Reddit as a high frustration point in 147. Recording where it can’t scroll to the beginning https://streamable.com/oxdn6u

https://www.reddit.com/r/firefox/comments/1p9mqgj/firefox_android_marking_text_in_the_url_bar_is/

Comment 4

[Petru-Mugurel Lingurar [:petru]]

This is a bug in the upstream component we're using that Google recently said they won't fix - https://issuetracker.google.com/issues/459087295.
Will be looking for a workaround in code but until then there is a simple workaround for user interactions: scroll the text by swiping it manually left-right instead of scrolling it through the cursor.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1999177 - Support cursor scroll in the composable toolbar r=#android-reviewers

By using the BasicTextField version with TextFieldState instead of the one
with TextFieldValue.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae35529fabc6
https://hg.mozilla.org/integration/autoland/rev/354cd56c4487
Support cursor scroll in the composable toolbar r=android-reviewers,moyin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a5862a7e7064
https://hg.mozilla.org/integration/autoland/rev/43e127c6f2be
Revert "Bug 1999177 - Support cursor scroll in the composable toolbar r=android-reviewers,moyin" for causing linting failures on browser_ext_urlclassifier.js.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa5bbfd5adef
https://hg.mozilla.org/integration/autoland/rev/2fb332ae023a
Support cursor scroll in the composable toolbar r=android-reviewers,moyin

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2fb332ae023a

Comment 10

[Petru-Mugurel Lingurar [:petru]]

@QA Please help check this issue is fixed and nothing got broken in the UX for entering or editing the URL/search terms.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Mira Lobontiu (Android QA)]

Attachment: Screen_Recording_20251204_142708_Firefox Nightly.mp4

Verified as implemented on the latest Firefox for Android Nightly 147.0a1 from 12/4 using a Samsung Galaxy S24 (Android 15), and a Pixel 6 (Android 16).

Comment 14

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Brings parity between the old and the new toolbar through supporting a common UX scenario: being able to scroll the currently edited URL by dragging the edit cursor to the beginning or end of said url.
  Comes to ensure that when the new toolbar is enabled through Nimbus for most users in release it would have all the expected functionality.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2001290#c0
• Risk associated with taking this patch: medium
• Explanation of risk level: Complex functionality verified though by QA.
• String changes made/needed: --
• Is Android affected?: yes

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1999177 - Support cursor scroll in the composable toolbar

By using the BasicTextField version with TextFieldState instead of the one
with TextFieldValue.

Original Revision: https://phabricator.services.mozilla.com/D274742

Comment 16

[Dianna Smith [:diannaS]]

petru this requires a rebased patch to release. The current patch conflicts because bug 1983833 is not in release.. Nvm I'm not sure why i was getting errors, but just kicked off a try build to make sure the linting failure wont occur when uplifted https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=168777

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a3baa932901f
https://hg.mozilla.org/releases/mozilla-release/rev/ed0b2d995e7a

Comment 18

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Beta 147.0b3 using a Motorola Moto G30 (Android 12), and a Lenovo TB X606X (Android 10).

Comment 20

[Lorand Janos]

Attachment: Edited_20251218_102838.mp4

Verified on the latest RC 146.0.1 build.

The caret can be placed in any position in the URL.

Device used: Samsung Galaxy S25 Ultra (Android 15).

Marking the ticket as verified on 146 as well.