1994077 - Upload important-dates suggestions for en locales in DE, FR, and IT

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

1. Update the upload scripts for important dates suggestions so that they upload en suggestions for DE, FR, and IT
2. Upload the suggestions

Comment 1

[Drew Willcoxon :adw]

en suggestions for DE, IT, and FR are now on RS stage. Once they're verified, I'll copy them to prod and close this bug.

For QA verification, please verify a couple of things:

1. The previous important-dates suggestions should still work: en suggestions in the US and UK; de suggestions in DE; fr suggestions in FR; and it suggestions in IT
2. The new suggestions: en suggestions in DE, FR, and IT

The full lists of dates and keywords are here:

• 2025
• 2026

They're the same as before, except I added two new tabs per EU country, where the tab name is "<locale>-<country>". For example, "en-DE" are en suggestions for Germany.

Comment 2

[Dana Lucaci, Desktop QA]

QA has completed the testing required for the RS update as follows:

• regression testing for en-US/US, en-GB/GB, de/DE, fr/FR,it/IT on stage with no issues with results here
• verified the RS update on stage with no issues with results here
  Questions:

1. During testing we have noticed that the title of the bug hints to the fact that en-* locales should support the new regions (FR,DE,IT) - we only covered during testing the en-US: en-GB+it/fr/de and en-CA+it/fr/de do not return important dates - could you advise if is this expected?
2. With the new changes in the localization/region coverage in the RS, should the default values for the feature in the en-us + FR/DE/IT (browser.urlbar.importantDates.featureGate and browser.urlbar.quicksuggest.enabled) be updated as well?

Comment 3

[Drew Willcoxon :adw]

Thanks Dana!

1. All en-* locales should be supported for the EU countries. I've tested using both en-GB and en-US with my browser.search.region to set to DE, and I was able to trigger the en-DE important dates (using the stage server). So could you try again please? I can post my full STR if it would help.

2. Sorry, my fault for not making this clear -- this bug is a follow-up to bug 1992811, which did change the default values of those two prefs from false to true for en-* locales in those EU countries. That bug just landed recently, so it's only on 146. (No plans to uplift.) So if you test with 146 with an en-* locale and set your region to one of those countries (and then restart Firefox), you should see that those two prefs are true. If you test on 145, it's expected that the prefs will remain false, and the en suggestions for these countries can't be triggered.

Comment 4

[Dana Lucaci, Desktop QA]

Hi Drew,

QA has completed testing for all en-* locales, as follows:

• Verified the RS update on Stage with en-GB + DE/FR/IT and en-CA + DE/FR/IT, with no issues found. Results here.
• Verified the browser.urlbar.importantDates.featureGate and browser.urlbar.quicksuggest.enabled pref states for both 145 and 146 builds and indeed, on 146 builds with en-* locales and DE/FR/IT regions, the default values for both prefs are true, while on 145 builds with the same locales and regions, the default values are false.

Thank you!

Comment 5

[Drew Willcoxon :adw]

Thanks Dana! The data has been copied to RS prod, so I'll close this bug now. I'm not sure you need to verify again since the data is the same, but if you have time, please feel free.

(I also updated the uploader script.)