1992811 - Enable important-dates suggestions for en locales in DE, FR, and IT

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Drew Willcoxon :adw]

This is a follow-up to bug 1985394. Nive says important-dates suggestions should be enabled for en locales in the EU3 countries: DE, FR, and IT. That means English-language suggestions for dates relevant to each country.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1992811 - Enable important-dates suggestions for en locales in DE, FR, and IT.

This enables Suggest and important-dates suggestions for en locales in the EU
countries. For these region-locales, Suggest itself will now be enabled, but
every feature of it will be disabled except for important dates. So, no AMP, no
Wikipedia, no settings UI, etc. IOW it will only be an implementation detail
that important dates are implemented using the Suggest platform.

I changed the default value of the settingsUI pref so that the settings UI
will be hidden by default. Right now, the default is to show the full UI. If I
didn't change the default, I would need to make more changes to how
QuickSuggest initializes default prefs (the SUGGEST_PREFS const) so that EU
countries would have branching logic for the settingsUI pref depending on the
locale, which is not currently possible.

Currently there isn't any data in remote settings for these region-locales, so
even with this patch, important dates won't be able to be triggered. I'll upload
some data later.

Depends on D268042

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c56b4740e9eb
https://hg.mozilla.org/integration/autoland/rev/04f1335cc821
Enable important-dates suggestions for en locales in DE, FR, and IT. r=daisuke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f5625a706d48
https://hg.mozilla.org/integration/autoland/rev/e53ce5540bdf
Revert "Bug 1992811, Bug 1993371, Bug 1966166 - Enable important-dates suggestions for en locales in DE, FR, and IT. r=daisuke" for causing failures at test_RustSharedRemoteSettingsService.js.

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_RustSharedRemoteSettingsService.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/e53ce5540bdf680a53de9bb0b03b411f2ca992b9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=04f1335cc821d299065145b9340183a4ff82d68c&selectedTaskRun=W1mYX1TNTiqyu_6kHTBYlA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=531208726&repo=autoland&task=W1mYX1TNTiqyu_6kHTBYlA.0&lineNumber=2117

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a40d6c8e811
https://hg.mozilla.org/integration/autoland/rev/a32fbd6d923c
Enable important-dates suggestions for en locales in DE, FR, and IT. r=daisuke

Comment 6

[Drew Willcoxon :adw]

This won't be verifiable until bug 1994077 is fixed, so I'll flag that bug for verification instead of this one.

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a32fbd6d923c

Comment 8

[Dianna Smith [:diannaS]]

:adw did you want to mention this in the 146 release notes? Please nominate if so.

Comment 9

[Drew Willcoxon :adw]

Release Note Request (optional, but appreciated)
[Why is this notable]: This is a new type of suggestion in the address bar for users of en locales in France, Germany, and Italy.
[Affects Firefox for Android]: No
[Suggested wording]: For people using English-language versions of Firefox in France, Germany, and Italy, the address bar will now show English-language suggestions for holidays and other important dates.
[Links (documentation, blog post, etc)]: None

Comment 10

[Drew Willcoxon :adw]

(FYI I edited the previous comment)

Comment 11

[Dianna Smith [:diannaS]]

Added to the 146 nightly release notes:
https://www.firefox.com/en-US/firefox/146.0a1/releasenotes/

Comment 12

[Drew Willcoxon :adw]

On second thought it would be good to verify that this bug did not make any unintended changes!

STR:

For Firefox builds using native locales in DE, FR, and IT regions

• The settings UI should reflect the fact that Firefox Suggest is enabled. i.e.:
  • The "Suggestions from Firefox/Nightly" and "Suggestions from sponsors" checkboxes should be visible
  • The "Improve the Firefox Suggest experience" toggle switch under those checkboxes should be hidden (yes, hidden)
• You should be able to trigger AMP and Wikipedia suggestions (no need to go overboard, checking just one suggestion for each is fine)

For Firefox builds using en locales in DE, FR, and IT regions

• The settings UI should reflect the fact that Firefox Suggest is not enabled. i.e.:
  • The "Suggestions from Firefox/Nightly" and "Suggestions from sponsors" checkboxes should be hidden
  • The "Improve the Firefox Suggest experience" toggle switch under those checkboxes should be hidden
• You should not be able to trigger AMP and Wikipedia suggestions

Comment 13

[Dana Lucaci, Desktop QA]

Hi Drew,
We tried to trigger the AMP and Wikipedia suggestions for the DE/FR/IT locales using the DE/FR/IT regions, but without success. Could you please share a list of keywords that might trigger suggestions specific to these locales/regions?

Thank you!

Comment 14

[Drew Willcoxon :adw]

Ah I'm sorry, I was wrong about the native locales. We did not enable AMP and Wikipedia by default. Instead, we shipped a Nimbus experiment to those countries that enables AMP and Wikipedia for 10% of the population. Actually -- it's confusing, but there is one experiment and one rollout:

• Firefox Suggest Geo Expansion - EU re-ramp - An experiment that targets 10% of native-locale users in those three countries
• Firefox Suggest Geo Expansion Firefox 141+ - A rollout that targets 100% of the users in the above experiment

The reason there's both an experiment and a rollout is that we added the ampFeatureGate and wikipediaFeatureGate Nimbus variables after the experiment shipped, and in order to keep those same users enrolled in AMP and Wikipedia, we shipped the rollout that targets all of the users in the experiment and adds the new variables.

So in summary 10% of native-locale users in those countries should be getting AMP and Wikipedia. And if you need to test it, you'll need to enroll first in the experiment and then in the rollout.

Comment 15

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Thank you, @Drew, for the context and all the details. I have enrolled in the experiment, then in the rollout using native locale in IT, FR, and DE, but I cannot trigger any AMP or Wikipedia suggestions.
I am not sure if I'm missing something or if there is an issue with these suggestions. I have logged a separate bug for it, with more information: Bug 1996203.

Comment 16

[Drew Willcoxon :adw]

Clearing the NI since we discussed it in bug 1996203