Closed Bug 1994212 Opened 1 year ago Closed 1 year ago

browser_sidebar_context_menu.js test depends on browser_customize_sidebar.js or something

Categories

(Firefox :: Sidebar, task, P1)

task

Tracking

()

RESOLVED FIXED
146 Branch
Tracking Status
firefox146 --- fixed

People

(Reporter: arai, Assigned: sfoster)

References

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 external file)

Running browser_sidebar_context_menu.js test alone locally fails with the following assertion failure.

https://searchfox.org/firefox-main/rev/d8e526c7b71d9e29b68bb61ccfcd3318e75e4aa1/browser/components/sidebar/tests/browser/browser_sidebar_context_menu.js#23

ok(BrowserTestUtils.isVisible(sidebar), "Sidebar is shown.");

It passes if I run the entire browser/components/sidebar/tests/browser directory.
And apparently it depends on browser_customize_sidebar.js's modification.
So, there are two issues:

I guess it's something with pref or internal state, but haven't yet figured out what it is.

Yeah there's a few problems compounding here. I'll take a look.

Assignee: nobody → sfoster
Severity: -- → N/A
Type: defect → task
Priority: -- → P1
Whiteboard: [fidefe-sidebar]
Duplicate of this bug: 1994774
Attachment #9520624 - Attachment description: Bug 1994212 - Dispatch a event when the sidebar context menu is populated and update that test to account for asyncronicity. r?#sidebar-reviewers! → Bug 1994212 - Dispatch an event when the sidebar context menu is populated and update that test to account for asyncronicity. r?#sidebar-reviewers!
See Also: → 1994508
Pushed by sfoster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9f26b7051866 https://hg.mozilla.org/integration/autoland/rev/b3dac2b19de2 Dispatch an event when the sidebar context menu is populated and update that test to account for asyncronicity. r=kcochrane
No longer blocks: 1952285
See Also: → 1952285
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
QA Whiteboard: [qa-triage-done-c147/b146]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: