1994700 - Accessing, editing or deleting profiles fails when the original profile has a custom location

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Simona Badau, Desktop QA]

Found in

• Nightly 146.0a1

Affected versions

• Nightly 146.0a1
• Firefox 145.0b2
• Firefox 144
• Firefox 140.4.0 esr

Tested platforms

• Affected platforms: Windows 11, Ubuntu 25.04 and macOS 15.

Preconditions

• Create a new profile using the Profile Manager and set a custom location for it (e.g. a folder on the Desktop).

Steps to reproduce

1. Open Firefox with the profile from the preconditions and create two switchable profiles (Profile A and Profile B).
2. In the original profile, click Manage Profile.
3. Delete Profile A.
4. Close the original profile.
5. Close Profile B.
6. Launch Firefox, and from the Profile Selector, click on the original profile.

Expected result

• In step 3 - Profile A should be deleted.
• In step 6 - the Original Profile should be launched successfully.

Actual result

• In step 3 - Profile A is not deleted nothing happens when clicking the Delete Button.
• In step 6 - the original profile cannot be accessed, deleted, or edited. For more details please see the screen recording.

Regression range

• Not a regression, reproducible on all Firefox versions.

Additional notes

• This is the error caught in the Browser Console:
  Uncaught (in promise) DOMException: PathUtils.joinRelative: Could not append to path: NS_ERROR_FILE_UNRECOGNIZED_PATH

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey :mossop - I'm not sure how to categorize the severity here. I'm curious, do we have similar bugs with the toolkit profile service? I suppose it might be due to using relative paths in the database--but we use relative paths in profiles.ini too. Not a MAX_PATH bug, since it occurs on platforms other than windows.

Comment 2

[Dave Townsend [:mossop]]

Particularly now that we support migrating profiles from profiles.ini we have to support paths outside of the expected location. I think we just need to replace the use of joinRelative which doesn't support .. components.

Comment 3

[Dave Townsend [:mossop]]

Attachment: Bug 1994700: Correctly resolve relative paths from the database. r=#profiles-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f58b60e4163f
https://hg.mozilla.org/integration/autoland/rev/8c31eda5b570
Correctly resolve relative paths from the database. r=profiles-reviewers,jhirsch

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8c31eda5b570

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox 148.0b4 and Nightly 149.0a1 on Windows 11 x64, macOS 15 and Ubuntu 24.04 - accessing, editing or deleting profiles doesn't fail anymore when the original profile has a custom location.