1995062 - Convert Backup settings to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Hanna Jones [:hjones]]

The Backup section on the Sync settings page should be converted to the config-based settings system.

These changes can be made on the existing page. The end result should be the following options:

• when backup is ON
  • backup location folder picker input
  • show in folder button
  • edit button
  • backup sensitive data checkbox
  • additional "change password" button when backup sensitive data is enabled
• when backup is ON or OFF
  • backup status indicator
  • manage backup button that opens the existing dialog
  • restore your data button that opens the existing dialog
  • backup now button that is enabled/disabled depending on whether or not backup is turned on

Comment 1

[Hanna Jones [:hjones]]

Attachment: elements we still need mockups for

Taking a look at this again after we were talking about marking things as "ready for dev" today. It looks like we're missing mockups for the elements that are unique to when the backup is "ON" - I've highlighted these elements in the red box above.

cc: jules - just putting this on your radar again

Comment 2

[Jules Simplicio [:jules]]

We talked about this on Slack; removing my ni?

Comment 3

[Hanna Jones [:hjones]]

Attachment: Bug 1995062 - Part 1: render backup-settings via config r=#recomp-reviewers

Comment 4

[Hanna Jones [:hjones]]

Attachment: Bug 1995062 - Part 2: convert backup-settings to match new settings UI r=#recomp-reviewers,#backup-reviewers

Comment 5

[Hanna Jones [:hjones]]

Attachment: Bug 1995062 - Part 3: fix backup-settings tests r=#recomp-reviewers,#backup-reviewers

Comment 6

[Hanna Jones [:hjones]]

Attachment: Bug 1995062 - Part 4: add tests and stories for new component functionality r=#recomp-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a0cd66af2ba
https://hg.mozilla.org/integration/autoland/rev/b7598163a447
Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/9f688bc6a83e
https://hg.mozilla.org/integration/autoland/rev/a4c75c10a93d
Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/93c2ac4c425f
https://hg.mozilla.org/integration/autoland/rev/158967da221c
Part 3: fix backup-settings tests r=cdupuis,akulyk
https://github.com/mozilla-firefox/firefox/commit/d3b65ef24810
https://hg.mozilla.org/integration/autoland/rev/8eea3aced268
Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/563493d9aa9b
https://hg.mozilla.org/integration/autoland/rev/7ea3b57007cc
Revert "Bug 1995062 - Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles" for causing bc failures @ browser_backup_visibility

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_backup_visibility

Backout link: https://hg.mozilla.org/integration/autoland/rev/7ea3b57007ccceb9c2bbfcd97ffb10a97be4b3a1

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_backup_visibility.js | backup should not be in search results

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c301308e4702
https://hg.mozilla.org/integration/autoland/rev/2f647b7b937f
Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/79ef5de66aa7
https://hg.mozilla.org/integration/autoland/rev/fcbe78d8d69a
Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/d9a11b9e5ea1
https://hg.mozilla.org/integration/autoland/rev/27f51bfeaade
Part 3: fix backup-settings tests r=cdupuis,akulyk
https://github.com/mozilla-firefox/firefox/commit/c8d2f4e96f0d
https://hg.mozilla.org/integration/autoland/rev/f75350f5e689
Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ba689ce11d6
https://hg.mozilla.org/integration/autoland/rev/a48bb9deddd4
Revert "Bug 1995062 - Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles" for causing @ mozilla::PathUtils::InitFileWithPath related process crashes.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8473191ea2af
https://hg.mozilla.org/integration/autoland/rev/b71a64898994
Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/92f1deb41e6a
https://hg.mozilla.org/integration/autoland/rev/1be21e23677b
Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/a8fdc42f1ae2
https://hg.mozilla.org/integration/autoland/rev/863f24f8b47f
Part 3: fix backup-settings tests r=cdupuis,akulyk
https://github.com/mozilla-firefox/firefox/commit/27b3c494362a
https://hg.mozilla.org/integration/autoland/rev/b81595d44ec6
Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6b3d5642bff
https://hg.mozilla.org/integration/autoland/rev/d3e7c7a3ad2e
Revert "Bug 1995062 - Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles" for causing failures complaining about PathUtils.

Comment 14

[Atila Butkovits]

Backed out for causing failures complaining about PathUtils.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d3e7c7a3ad2e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b81595d44ec6ca796746a1e26364dfdb543d528d&selectedTaskRun=UMV4hF3TTzSHp0EO92m0eg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=547490394&repo=autoland&task=UMV4hF3TTzSHp0EO92m0eg.0&lineNumber=2159

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0c6ca5b99390
https://hg.mozilla.org/integration/autoland/rev/673303be87ee
Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/d35a938c7421
https://hg.mozilla.org/integration/autoland/rev/14f2cac16c05
Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/374462b92394
https://hg.mozilla.org/integration/autoland/rev/e22a74562a2a
Part 3: fix backup-settings tests r=cdupuis,akulyk
https://github.com/mozilla-firefox/firefox/commit/0248bd66c2a8
https://hg.mozilla.org/integration/autoland/rev/1f01e4133753
Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/905545407289
https://hg.mozilla.org/integration/autoland/rev/e2a8495e0ebc
Revert "Bug 1995062 - Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles" for causing crashtest failures @test_backup_settings.html.

Comment 17

[agoloman]

Backed out for causing crashtest failures @test_backup_settings.html.

• Backout link
• Push with failures
• Failure Log

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3d5e3233f569
https://hg.mozilla.org/integration/autoland/rev/86f87884f5be
Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/d7951ffb6af1
https://hg.mozilla.org/integration/autoland/rev/8820b534684f
Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/6c910b55efc7
https://hg.mozilla.org/integration/autoland/rev/61c427338052
Part 3: fix backup-settings tests r=cdupuis,akulyk
https://github.com/mozilla-firefox/firefox/commit/de8e4bce303c
https://hg.mozilla.org/integration/autoland/rev/6b2f3a1065cd
Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/040d092d23d0
https://hg.mozilla.org/integration/autoland/rev/cc979f253ff5
Revert "Bug 1995062 - Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles" for causing mochitest failures @PathUtils.cpp

Comment 20

[pstanciu]

Backed out for causing mochitest failures @PathUtils.cpp

• https://hg.mozilla.org/integration/autoland/rev/cc979f253ff5a923354835f58e7e862bb6399c53
• Push with failures
• Failure Log

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a289d6c69eb
https://hg.mozilla.org/integration/autoland/rev/3646478b15ff
Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/9e8e985a8ded
https://hg.mozilla.org/integration/autoland/rev/b9bfac081baf
Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles
https://github.com/mozilla-firefox/firefox/commit/0b9475a4cf22
https://hg.mozilla.org/integration/autoland/rev/2f8e18c1bb9c
Part 3: fix backup-settings tests r=cdupuis,akulyk
https://github.com/mozilla-firefox/firefox/commit/66dfea2f6170
https://hg.mozilla.org/integration/autoland/rev/7d572d37f136
Part 4: add tests and stories for new component functionality r=desktop-theme-reviewers,akulyk,tgiles

Comment 22

[rperta]

https://hg.mozilla.org/mozilla-central/rev/3646478b15ff
https://hg.mozilla.org/mozilla-central/rev/b9bfac081baf
https://hg.mozilla.org/mozilla-central/rev/2f8e18c1bb9c
https://hg.mozilla.org/mozilla-central/rev/7d572d37f136