1995579 - The comment dialog pop-up might spill out of the viewport if the browser window is a smaller size

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Attachment: comment pop-up spills out when window is small.png

Note

• When a smaller browser window is used and a comment pop-up is opened, it might spill out of the window. A horizontal scrollbar is not created to accpunt for the spillout.
• This issue more likely occurs when the comment is placed in the middle of the page because it opend to a side or another. In this case, our suggestion would be to center the pop-up in the available wiewport and add a horizontal scrollbar to compensate for further spilling.

Found in

• Beta v145.0b4

Affected versions

• Beta v145.0b4
• Nightly v146.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: none

Steps to reproduce

1. Load a PDF.
2. Insert an annotation (Highlight, signature, text insert, etc.) in the center of the document.
3. Attach a somewhat longer comment.
4. Make the browser window smaller (1/3 of the screen width)
5. Open the in-content comment pop-up.

Expected result

• The comment might spill out of the viewport; no horizontal scrollbar present.

Actual result

• The comment is centered inside the viewport; horizontal scrollbar is present to compensate for spills.

Regression range

• Not a regression.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Make sure the left (resp. right) corner of the popup is visible when in LTR (resp. RTL) (bug 1995579) (#20389)

Comment 2

[Daniel Bodea [:danibodea]]

I can confirm this fix in Nightly v146.0a1 from 2028-10-24 and Beta v145.0b6 (treeherder builds). The fix was verified in Windows 10, MacOS 14.7.1 and Ubuntu 22. The pop-up no longer spills out as it is now automatically horizontally fit inside the viewport. The longer comments display downwords and a scrollbar is created to allow the user to easily scroll down and read it.