1995990 - Uplift few pdf.js patches in beta 145 in order to fix few comment issues

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Calixte Denizet (:calixte)]

We'll uplift the patches for bugs: 1994738, 1995028, 1995766, 1995721, 1995705, 1995579.

Comment 1

[Calixte Denizet (:calixte)]

Attachment: Bug 1995990 - Uplifts few pdf.js patches in order to fix few issues related to the commenting feature

It contains the following commits:

• fd3f7528b6ab96edaa1b160541433f869fcd846b (bug 1994738)
• 18a7a82c29f7aeac7607d10f107ea9cc8dbb1bda (bug 1995028)
• abfa1495d56d208336b94b2ff30c10882d1fd0b4 (bug 1995766)
• ad9bcabee32f6b84ddd169159f55b7a1364e948b (bug 1995721)
• 19cbdba434a8ed78755bdd9a7a0c90c18d1abc3a (bug 1995705)
• cb36dc28a71bfa08bc9db40e20bee80d11ee1194 (bug 1995579)

Comment 2

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: The new feature "adding a comment in a pdf" won't be in 145.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See the mentioned bugs in bu 1995990.
• Risk associated with taking this patch: low
• Explanation of risk level: Very small and self-contained changes.
  Each bug can be easily verified by QA.
• String changes made/needed: No
• Is Android affected?: no

Comment 3

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5bbcd3a8be73
https://hg.mozilla.org/releases/mozilla-beta/rev/53f55922c458

Comment 4

[Daniel Bodea [:danibodea]]

I have verified these fixes in Nightly v146.0a1 from 2028-10-24 and Beta v145.0b6 (in treeherder builds). The fixed were verified in Windows 10, MacOS 14.7.1 and Ubuntu 22. All fixes behave accordingly. Closing report.