1995766 - High Contrast accent color should be applied to the text input box container and the Comment Sidebar Close button in Windows 11 Night Sky Theme

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Attachment: Win11 Night Sky High Contrqast Theme.png

Note

• According to Figma, the yellow accent color should be applied to the Add/Edit comment text input box cxontainer and the Comment Sidebat Close button.

Found in

• Beta v146.0a1

Affected versions

• Beta v146.0a1
• Nightly v146.0a1

Tested platforms

• Affected platforms: Windows 11
• Unaffected platforms: Windows 10, MacOS, Ubuntu

Steps to reproduce

1. Enable Night Sky High Contrast theme.
2. Load a PDF.
   3.1 Create an annotation (highlight, etc.) and attach a comment.
   3.2 Open the Comment Sidebar.

Expected result

• The Add Comment text input box container edge would be solid yellow.
• The Comment Sidebar Close button should be yellow.

Actual result

• The Add Comment text input box container edge contains yellw, but also displays white.
• The Comment Sidebar Close button is white and missing an edge.

Regression range

• Not a regression.

Additional notes

• This report only relates to Windows 11 and Night Sky Theme, but the accent color should apply in all Windows 11 High Contrast themes.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Fix the css of the button to close the comment sidebar (bug 1995766) (#20386)

Comment 2

[Daniel Bodea [:danibodea]]

Attachment: Behavior after the fix.png

This is the behavior after the fix: The Comments Sidebar Close button is now bright yellow when using Night Sky High Contrast theme. Also, the text input box does have a (thinner than designed) bright yellow line when unfocused, however, when focused, a solid white line is also displayed around the text input box to show the focus. Because this is not a visibility issue and only a minor aestetic difference compared to design, I believe this to be acceptable.

The other Windows 11 High Contrast themes behave accordingly.

Comment 3

[Daniel Bodea [:danibodea]]

I can confirm this fix in Nightly v146.0a1 from 2028-10-24 and Beta v145.0b6 (treeherder builds). The fix was verified in Windows 11. Complete explanation of the changes can be seen above.