1996102 - Adding/removing a split view to/from a tab group is not working as expected

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser: Split View, defect, P2)

Description

[Kelly Cochrane [:kcochrane]]

Two issues are going on here:
We're unable to add an existing split view to a new tab group for some reason. I haven't investigated this too much, but it seems like the tab-group element and label are being added inside of the split view wrapper/container for some reason. Note that there is a separate bug on file (bug 1995543) for updating the verbiage of the context menu options for this. I also want to point out that you are able to add an existing split view to an existing tab group, so this is specific to adding an existing split view to a NEW tab group.

When removing a split view from a tab group, right clicking a split view tab and selecting "Remove Tab from Group" (which will also be updated in the context menu bug - bug 1995543), the one tab is removed from the group, but the other split view tab remains in the split view container within the tab group. When removing a split view tab from a group, we should actually be removing the entire split view from the group rather than one of the tabs within.

Specs
Tech Spec Doc

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1996102 - Fix issues with adding/removing a split view to/from tab groups

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1826f31a34d
https://hg.mozilla.org/integration/autoland/rev/d35be2b21ab8
Fix issues with adding/removing a split view to/from tab groups r=tabbrowser-reviewers,sthompson

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d35be2b21ab8

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! I have verified with Firefox 146.0a1 (2025-11-05) on Windows 11, macOS 15, and Ubuntu 24 that creating a new tab group by selecting the two tabs from a Split view is now possible.

However, there are two more issues here, and I don't know if they will be fixed in bug 1995543:

1. As stated in comment 0 when removing a split view from a tab group, right-clicking a split view tab and selecting Remove from Group will only remove the selected tab, and the other tab remains in the group
2. If we select both SplitView tabs that are in a group and then select Remove from group, both tabs are removed from the group, but they are no longer in a SplitView

Are the above issues addressed in bug 1995543, or should we file something new? Also is there something else that we should verify here? Thank you in advance!

Comment 5

[Kelly Cochrane [:kcochrane]]

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #4)

Hello! I have verified with Firefox 146.0a1 (2025-11-05) on Windows 11, macOS 15, and Ubuntu 24 that creating a new tab group by selecting the two tabs from a Split view is now possible.

However, there are two more issues here, and I don't know if they will be fixed in bug 1995543:

1. As stated in comment 0 when removing a split view from a tab group, right-clicking a split view tab and selecting Remove from Group will only remove the selected tab, and the other tab remains in the group
2. If we select both SplitView tabs that are in a group and then select Remove from group, both tabs are removed from the group, but they are no longer in a SplitView

Are the above issues addressed in bug 1995543, or should we file something new? Also is there something else that we should verify here? Thank you in advance!

Hi yes both will be addressed in bug 1995543

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Kelly Cochrane [:kcochrane] from comment #5)

Hi yes both will be addressed in bug 1995543

Thank you! Closing this.