1996526 - Theme colors are not inherited to webextension sidebars

Status: NEW

(Firefox :: Sidebar, defect, P3)

Description

[matthias koplenig [:metasieben]]

Attachment: sidebar header

Currently theme colors(sidebar_*) are not inherited to the webextpanels-window, leading to unreadable sidebar
headers and hard to see close-button.

Comment 1

[Sarah Clements [:sclements]]

Hi, what theme are you using? Is this the only extension or theme you're having this issue with?

Comment 2

[matthias koplenig [:metasieben]]

It's my own theme.
In this theme, sidebar_text would be #20272f with sidebar at #5bd2e6.

But this happens with all themes(even Alpenglow), it's only very obvious with sidebar background colors
that are lighter and a dark sidebar_text color.

See the difference between the heading in settings/internal dialogs and webextensions.

Comment 3

[matthias koplenig [:metasieben]]

Attachment: sidebarheader showing settings pane

Comment 4

[matthias koplenig [:metasieben]]

Attachment: sidebarheader showing webextension

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Ok I can kind of reproduce this. For webextensions with a sidebar, the browser#sidebar loads a webext-panels.xhtml. That document has a window#webextpanels-window root element that hosts the header and close button for the sidebar panel for web-extensions. And the panel content is loaded into a further nested browser#window#webextpanels-browser.

The outer document with #webextpanels-window and #sidebar-panel-header in does not seem to provide the CSS variables that would let a lightweight theme color these elements. I'm not sure to what extent that is intentional. The extension doesn't "own" the header area with the extension heading and close button. However, it should appear the same as the built-in sidebar content like the customize settings tool, so there is a bug here.

I'm proposing P3/S3 for now.

Comment 7

[Kestrel]

The "unreadable sidebar" comment #0 screenshot was likely caused by Bug 1984885 making the sidebar transparent instead of using default light/dark colors.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1984885, could you take a look?

For more information, please visit BugBot documentation.