1984885 - The color of the sidebar header does not change with the browser theme.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[kokoaa]

Attachment: fh.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:143.0) Gecko/20100101 Firefox/143.0

Steps to reproduce:

Under a non-system theme, open the sidebar interface of a sidebar extension.

Actual results:

The color of the header remains consistent with the system theme.

Expected results:

The color of the header follows the theme color.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:kcochrane, since you are the author of the regressor, bug 1974188, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

Kelly looked into this, seems like it may not be a recent regression.

Comment 3

[Kelly Cochrane [:kcochrane]]

Looks like the color applied to panel headers looks fine with some themes (ex: Firefox Alpenglow) but not others (ex: dark stars theme)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tgiles, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1984885 - Enable transparent background on webext sidebar panels and set better --sidebar-background-color default for lwthemes. r?#sidebar-reviewers,emilio

Not sure if this could be harmful for certain sidebar content, please review carefully. Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ebf376ca6756
https://hg.mozilla.org/integration/autoland/rev/935a682c44fe
Enable transparent background on webext sidebar panels and set better --sidebar-background-color default for lwthemes. r=emilio,desktop-theme-reviewers,sclements

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/935a682c44fe

Comment 8

[Simona Badau, Desktop QA]

Reproduced the initial issue using Firefox 145 on Ubuntu 24.04.

Verified as fixed using Firefox 146.0b2 on Ubuntu 24.04, Windows 11 x64 and macOS 14 - the color of the sidebar header is changed with the theme (used the Sidebery addon).