1997048 - Upgrade to ICU4X 2.1.1

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Henri Sivonen (:hsivonen)]

ICU4X 2.1.1 is now on crates.io. We should update to it as a general matter of keeping dependencies up-to-date, but, moreover, there are calendar changes that are likely relevant to Temporal and the performance of CodePointTrie is better, which improves multiple components.

Comment 1

[Makoto Kato [:m_kato]]

• ICU4X 2.1.1 requires Rust 1.83, but Gecko's minimal requirement is still 1.82. Bug 1986626 is filed to update minimal version, but TASN/ASAN sitll use Rust 1.81 due to library issue, so it isn't easy to update to 1.83+.
• Some calendar data are changed, so we need to adjust SpiderMonkey's tests.

https://treeherder.mozilla.org/jobs?repo=try&revision=f7c23d86ea08b8c8389dc654c1ffc1d8cce88137

Comment 2

[Henri Sivonen (:hsivonen)]

anba, what's going on with the Chinese associated ISO year in the tests?

Comment 3

[André Bargull [:anba]]

The code in https://searchfox.org/firefox-main/source/intl/components/src/calendar needs to be updated to handle the changed definitions of era years for Chinese/Dangi calendars. I'll attach a WIP patch for testing.

Comment 4

[André Bargull [:anba]]

Attachment: WIP: Bug 1997048: Use related Gregorian year as the era year for Chinese-based ICU4X calendars.

Drive-by change:

• Remove unused CalendarDate.

Comment 5

[Makoto Kato [:m_kato]]

Also, I guess that https://searchfox.org/firefox-main/rev/e61d59b5c9a651fd7bf28043f87c0dc669833496/js/src/builtin/temporal/Calendar.cpp#1545-1549 is unnecessary.

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=da9dd0bc2f6197d8f0c0525ff4fd5cc254a878e5

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1997048 - Part 1. Update update-icu4x.sh. r=TYLin!

icuexport filename rule is changed, so we should add an argument for it.

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Bug 1997048 - Part 2. Update patched ICU4X files in tree. r=TYLin!

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Bug 1997048 - Part 3. Vendor ICU4X 2.1.1. r=#supply-chain-reviewers!,TYLin!

Comment 10

[Makoto Kato [:m_kato]]

Attachment: Bug 1997048 - Part 4. Modify Gecko side to use ICU4X 2.1. r=TYLin!,anba!

ICU4X 2.1's FFI are

• diplomat's namespace is changed
• Remove a workarounds of calendar data to pass WPTs such as
  test262/intl402/Temporal/*/prototype/year/epoch-year.js.

Comment 11

[Makoto Kato [:m_kato]]

Attachment: Bug 1997048 - Part 5. Update unit tests and results for ICU4X 2.1 changes. r=anba!,TYLin!

I think we need to update some js tests to reflect changes in ICU4X 2.1.
Also, grapheme cluster is updated to Unicode 17.0, so Indic's breaking
behavior is changed.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fdd91c1e8450
https://hg.mozilla.org/integration/autoland/rev/7208b73a172b
Part 1. Update update-icu4x.sh. r=TYLin
https://github.com/mozilla-firefox/firefox/commit/ab62185a13b8
https://hg.mozilla.org/integration/autoland/rev/fdd2552fc5c2
Part 2. Update patched ICU4X files in tree. r=TYLin
https://github.com/mozilla-firefox/firefox/commit/03be30e5bc13
https://hg.mozilla.org/integration/autoland/rev/47e5e4c27c47
Part 3. Vendor ICU4X 2.1.1. r=TYLin,supply-chain-reviewers
https://github.com/mozilla-firefox/firefox/commit/9534bd00c317
https://hg.mozilla.org/integration/autoland/rev/b0f80cca985f
Part 4. Modify Gecko side to use ICU4X 2.1. r=TYLin,anba
https://github.com/mozilla-firefox/firefox/commit/ee8e70c6ec90
https://hg.mozilla.org/integration/autoland/rev/9ee11e18a0a4
Part 5. Update unit tests and results for ICU4X 2.1 changes. r=anba,TYLin

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7208b73a172b
https://hg.mozilla.org/mozilla-central/rev/fdd2552fc5c2
https://hg.mozilla.org/mozilla-central/rev/47e5e4c27c47
https://hg.mozilla.org/mozilla-central/rev/b0f80cca985f
https://hg.mozilla.org/mozilla-central/rev/9ee11e18a0a4

Comment 14

[:gerard-majax]

This seems to have introduced a duplication on embedded-io crate dependency: https://searchfox.org/firefox-main/rev/07e27bfce5acf193bdb89c7ba2aa73451a3e43b4/intl/icu_capi/Cargo.lock#731-732 we now have 0.4.0 and 0.6.1 ?