1999917 - No formatted output for large dates when using Chinese/Dangi calendars

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect, P3)

Description

[André Bargull [:anba]]

js> new Intl.DateTimeFormat("en-u-ca-chinese", {timeZone:"UTC"}).format(new Date("[phone]T00:00:00.000Z"))
"/"

Returning "/" indicates there's some issue with ICU.

Comment 1

[André Bargull [:anba]]

This is an issue in ICU4C's computeMonthInfo function:

• computeMonthInfo gets called with gyear=100000 and days=35804722.
• solsticeAfter is computed as 35805412.
• days=35804722 < solsticeAfter=35805412, so solsticeBefore is computed from gyear-1 = 99999. The computed value is solsticeBefore = 35805047.
• That means days=35804722 < solsticeBefore=35805047, so this check fails and U_ILLEGAL_ARGUMENT_ERROR is returned.

Updating to ICU4X 2.1.1 (bug 1997048) should allow to remove the fallback code in ICU4XChineseBasedCalendar, which should fix this bug.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1999917: Remove no longer needed ICU4C calendar fallback code. r=#spidermonkey-reviewers!

We no longer need the fallback code after the upgrade to ICU4X 2.1.1, because
ICU4X can now handle all supported years.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/818473254269
https://hg.mozilla.org/integration/autoland/rev/359bd42b605d
Remove no longer needed ICU4C calendar fallback code. r=spidermonkey-reviewers,dminor

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/359bd42b605d