1997106 - Explicitly RequestDecode in FetchDecodedImageHelper::OnImageReady

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Tom Schuster]

While testing out a newer version of my patches in bug 1988124, I noticed that we never end up decoding anything with the FetchDecodedImageHelper. The problem is that we abort early in Notify() because we don't have an mImage so we never request a decode. After the last Notify() call we get the OnImageReady call (which sets mImage), but no more Notify() calls afterwards that would give us the opportunity to request a decode. So we just get stuck.

Comment 1

[Tom Schuster]

Attachment: Bug 1997106 - Explicitly RequestDecode in FetchDecodedImageHelper::OnImageReady. r?tnikkel

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Seems like this would also fix the issue reported in bug 1996488.
Would be great to have this fixed in 146 before getting to affect more people.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0cbcfd42039b
https://hg.mozilla.org/integration/autoland/rev/da33f2fb5343
Explicitly RequestDecode in FetchDecodedImageHelper::OnImageReady. r=tnikkel

Comment 4

[Tom Schuster]

Comment on attachment 9523210 [details]
Bug 1997106 - Explicitly RequestDecode in FetchDecodedImageHelper::OnImageReady. r?tnikkel

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Broken extensions on Android (Bug 1996488)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: I don't know the details, please see bug 1996488.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple one-line change, but sadly no automated tests.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/da33f2fb5343

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Let's target that for the mobile dot release a week after shipping 145.0.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Seems like this has not resulted in the regression from bug 1998612 and did fix the issue from bug 1996488 (currently affecting beta as well).
Thank you for the quick fix Tom!

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

After talking with the devs, there is the possibility that this bug affects not only the new menu that has a partial rollout with 145.0, but also the current menu system. There is some risk here and we still have a window for an RC2.

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9523210 [details]
Bug 1997106 - Explicitly RequestDecode in FetchDecodedImageHelper::OnImageReady. r?tnikkel

Approved for 145.0RC2

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5acf4c550b9a
https://hg.mozilla.org/releases/mozilla-release/rev/c487c060d930

Comment 11

[Lorand Janos]

Attachment: Edited_20251107_083632.mp4

Verified as fixed on the latest RC build (145.0RC2) and on the latest Nightly build (146.0a1 from 2025-11-06).

The installed extensions are displayed in the Extensions section in the menu.

Devices used: Motorola Nexus 6 (Android 8), Samsung Galaxy S23 Ultra, S25 Ultra, OnePlus Pad 3 (Android 15).

Marking the ticket as verified on 145 and 146.