1997141 - The in-tree langpack RPMs have their `Supplements` field set to `firefox-langpacks-*` instead of `langpacks-*`

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Bastien Orivel [:eijebong]]

They are marked as supplementing firefox-langpacks-{codename} but it should be supplementing langpacks-{codename} to be installed automatically based on which langpacks are currently installed on the system.

See https://docs.fedoraproject.org/en-US/packaging-guidelines/Langpacks/

Comment 1

[Bastien Orivel [:eijebong]]

Attachment: Bug 1997141 - Properly name XPI files in the langpack RPM packages. r=#releng-reviewers

Firefox expects XPI files in distribution/extensions to be named with
their ID or it throws exceptions on startup like
/usr/lib/firefox-nightly/distribution/extensions/[e-mail] contains an add-on with an incorrect ID.

The previous code would use the package name but the langpack XPI ID is
actually using the remoting name (firefox/devedition) and does not
contain the track for which it was built. So we ended up with
[e-mail] instead of
[e-mail] for nightly builds (same issue
with beta), which prevents the langpack from loading.

Comment 2

[Bastien Orivel [:eijebong]]

Attachment: Bug 1997141 - Fix langpacks `Supplements` field in RPM package. r=#releng-reviewers

According to the Fedora packaging guidelines 1, langpacks provided
with packages should be marked as supplementing the package itself as
well as langpack-{locale}. The current RPM was wrongly supplementing
the package name and package-name-langpacks-{locale} which resulted in
it not being picked up when installing the RPM.

Comment 3

[Phabricator Automation]

Comment on attachment 9523275 [details]
Bug 1997141 - Properly name XPI files in the langpack RPM packages. r=#releng-reviewers

Revision D270551 was moved to bug 1997143. Setting attachment 9523275 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/21c7a83374e1
https://hg.mozilla.org/integration/autoland/rev/fe0e654d1b19
Fix langpacks `Supplements` field in RPM package. r=releng-reviewers,ahal DONTBUILD

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fe0e654d1b19