1997393 - Support hidden options in moz-select

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Emma Zühlcke [:emz]]

The moz-select component ignores the hidden attribute on moz-option elements. Same as Bug 1997185 but for the hidden attribute.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1997393 - Support hidden options in moz-select. r=#recomp-reviewers!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1997393 - Add storybook stories and tests for disabled and hidden moz-option properties. r=#recomp-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fcf324e8a531
https://hg.mozilla.org/integration/autoland/rev/a8c1f3b999ab
Support hidden options in moz-select. r=hjones
https://github.com/mozilla-firefox/firefox/commit/d08dee73fb25
https://hg.mozilla.org/integration/autoland/rev/418a28b85c5e
Add storybook stories and tests for disabled and hidden moz-option properties. r=hjones

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1997393 - Fix jsdoc lint error.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/68d1b36f5c56
https://hg.mozilla.org/integration/autoland/rev/fb3983a4f47d
Revert (Bug 1997393, Bug 1971438, Bug 1997185) for causing bc failures @ browser_sanitizeDialog_v2.js

Comment 6

[amarc]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log
  Please also fix the lint failure when relanding -> https://phabricator.services.mozilla.com/D272134

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a1e6c562a42
https://hg.mozilla.org/mozilla-central/rev/0c6369754cef
Support hidden options in moz-select. r=hjones
https://github.com/mozilla-firefox/firefox/commit/5d51677ea1d7
https://hg.mozilla.org/mozilla-central/rev/49e343d7754f
Add storybook stories and tests for disabled and hidden moz-option properties. r=hjones
https://github.com/mozilla-firefox/firefox/commit/0d3006309def
https://hg.mozilla.org/mozilla-central/rev/5eb57b928267
Revert (Bug 1997393, Bug 1971438, Bug 1997185) for causing bc failures @ browser_sanitizeDialog_v2.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bf3d09728e6f
https://hg.mozilla.org/integration/autoland/rev/cb442482f7cd
Support hidden options in moz-select. r=hjones
https://github.com/mozilla-firefox/firefox/commit/c0ed632a456f
https://hg.mozilla.org/integration/autoland/rev/fe62067558a6
Add storybook stories and tests for disabled and hidden moz-option properties. r=hjones

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cb442482f7cd
https://hg.mozilla.org/mozilla-central/rev/fe62067558a6