1971438 - Convert History to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P1)

Description

[Mark Striemer [:mstriemer]]

The History section on the Privacy & Security settings page should be converted to the config-based settings system.

These settings include a sub-page in the new design which may justify creating a new version, rather than replacing the old one. In the interim, the settings could likely be kept together in the existing Privacy & Security page, but this could result in a very noise UI (hiding the nested items under custom unless it is selected could help).

The end result should be the following settings:

• History radio group
• Remember history
• Never remember history
• Customize history
  • Always use private browsing mode checkbox
    • Remember browsing and download history checkbox
    • Remember search and form history checkbox
    • Clear when Firefox closes checkbox
      • Advanced settings button (opens the existing dialog)

There are still open questions in the Figma:

• The clear history button appears to be missing from the design. Is it being removed?
• The customize history design does not appear to be finalised, bug 1969398 may need to be considered.
• The settings button for "Clear history when Nightly closes" is currently dependent on the checkbox being enabled. Should it be nested in the new design because of this?

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1971438 - Convert History to config-based prefs. r=#settings!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1971438 - Update tests for history preferences section. r=#settings!

Comment 3

[Emma Zühlcke [:emz]]

Depends on Bug 1997185 so enterprise policy can disable private browsing autostart ("never remember history").

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1971438 - Support setting 'disabled' and 'hidden' properties via 'option' config. r=#settings!

Comment 5

[Emma Zühlcke [:emz]]

Attachment: Bug 1971438 - Add storybook stories and tests for disabled and hidden moz-option properties. r=#settings!

Comment 6

[Phabricator Automation]

Comment on attachment 9525786 [details]
Bug 1971438 - Add storybook stories and tests for disabled and hidden moz-option properties. r=#settings!

Revision D272065 was moved to bug 1997393. Setting attachment 9525786 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8079415014df
https://hg.mozilla.org/integration/autoland/rev/b81a67777a11
Convert History to config-based prefs. r=fluent-reviewers,mconley,bolsson
https://github.com/mozilla-firefox/firefox/commit/00e35ddfe9b0
https://hg.mozilla.org/integration/autoland/rev/1a36f4c2680c
Update tests for history preferences section. r=mconley
https://github.com/mozilla-firefox/firefox/commit/0a681e6e150c
https://hg.mozilla.org/integration/autoland/rev/060d5b0f7841
Support setting 'disabled' and 'hidden' properties via 'option' config. r=hjones

Comment 8

[amarc]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log
  Please also fix the lint failure when relanding -> https://phabricator.services.mozilla.com/D272134

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d11399d46900
https://hg.mozilla.org/mozilla-central/rev/75e49c01253d
Convert History to config-based prefs. r=fluent-reviewers,mconley,bolsson
https://github.com/mozilla-firefox/firefox/commit/815dcbccd91a
https://hg.mozilla.org/mozilla-central/rev/70383d82b626
Update tests for history preferences section. r=mconley
https://github.com/mozilla-firefox/firefox/commit/28f04acb4994
https://hg.mozilla.org/mozilla-central/rev/5acb29256940
Support setting 'disabled' and 'hidden' properties via 'option' config. r=hjones

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6dae370b4a5
https://hg.mozilla.org/integration/autoland/rev/3d64f67d006a
Convert History to config-based prefs. r=fluent-reviewers,mconley,bolsson
https://github.com/mozilla-firefox/firefox/commit/37c9f6ef4c7a
https://hg.mozilla.org/integration/autoland/rev/3897d202df7d
Update tests for history preferences section. r=mconley
https://github.com/mozilla-firefox/firefox/commit/d15fc38a711d
https://hg.mozilla.org/integration/autoland/rev/21055f3ae5f7
Support setting 'disabled' and 'hidden' properties via 'option' config. r=hjones

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3d64f67d006a
https://hg.mozilla.org/mozilla-central/rev/3897d202df7d
https://hg.mozilla.org/mozilla-central/rev/21055f3ae5f7