Open Bug 1997752 Opened 2 months ago Updated 17 days ago

Firefox Tabs in Taskbar not using correct icon

Categories

(Firefox :: Web Apps, defect, P2)

Firefox 144
Unspecified
Windows
defect

Tracking

()

ASSIGNED

People

(Reporter: itsleemcguire, Assigned: dmcintosh)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:144.0) Gecko/20100101 Firefox/144.0

Steps to reproduce:

Go to gmail, or google calendar, click "Add tab to taskbar"

Actual results:

Tab installs on taskbar not with Gmail icon but an ugly black globe, image attached

Expected results:

The Gmail icon should be in taskbar, using the favicon from the site. It works with all other websites

The Bugbug bot thinks this bug should belong to the 'Firefox::Web Apps' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Web Apps

Hello, thank you for the bug report!

Managed to reproduce this issue on:

  • Firefox Nightly 146.0a1;
  • Firefox 145.0b9;
  • Firefox 144.0.2;

Tested and reproduced on Windows 10.

Setting as NEW.

Status: UNCONFIRMED → NEW
Ever confirmed: true

@nrishel Could you please help me set a severity for this?

Flags: needinfo?(nrishel)

:oardelean is this a consistent issue or does it take a few attempts?

Flags: needinfo?(nrishel) → needinfo?(oardelean)

This is a consistent issue, I can reproduce from the first try.

STR:

  1. Launch Fx.
  2. Navigate to calendar.google.com or mail.google.com and login using a valid account.
  3. Once logged in, click on the 'Add tab to taskbar' button from the address bar.
Flags: needinfo?(oardelean)
Whiteboard: [fidedi-pbm]
Severity: -- → S3
OS: Unspecified → Windows 10
Priority: -- → P2
Whiteboard: [fidedi-pbm]

We figure out what icon to display using the app's start URL, which for GMail is /mail/. However, favicons are organized per-path, so e.g. /a/b/c can have a different icon than /a/b (which is true, they can be different). The user never actually stays on /mail/ before getting redirected to /mail/u/0, so we don't actually have a favicon saved, giving the black globe.

I'll try looking into fixing this, I suspect this'd open the door to manifest icons (bug 1979462) too.

Assignee: nobody → dmcintosh
Status: NEW → ASSIGNED
OS: Windows 10 → Windows

(In reply to Duncan McIntosh [:dmcintosh] from comment #6)

We figure out what icon to display using the app's start URL, which for GMail is /mail/. However, favicons are organized per-path, so e.g. /a/b/c can have a different icon than /a/b (which is true, they can be different). The user never actually stays on /mail/ before getting redirected to /mail/u/0, so we don't actually have a favicon saved, giving the black globe.

I'll try looking into fixing this, I suspect this'd open the door to manifest icons (bug 1979462) too.

I have tried to webapp the url mail.google.com/mail/u/0/#inbox and that still shows the black globe, and the same with Google Calendar too.

Duplicate of this bug: 2001110
Depends on: 2000947

(Tuning in from a duplicate ticket: 2001110 where some other sites were problematic too...)

Just wanted to note that I didn't experience this bug until recently. My memory of which Firefox version I started using the new PWA feature is foggy, but it did work as expected before (maybe in v143?). I'm not sure if something changed in Firefox itself, with the sites I'm using, or with Windows 11 -- but just wanted to call out in case that's helpful.

This only affects shortcut creation; the icon saving should be moved into
TaskbarTabs.sys.mjs to be used for the window icon.

Moving away from the old getFavicon interface was needed to distinguish
whether getting the favicon succeeded. It's also useful in tests,
especially combined with the added encodePNG function, and it will make
manifest icons much easier.

Thanks for looking into this. Looks like chat.google.com has the same issue!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: