1997925 - The notification dot is not displayed if the tab is in a Split View

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Split View, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: split_notification.gif

Found in

• 146.0a1 (2025-11-02)

Affected versions

• 146.0a1 (2025-11-02)

Tested platforms

• Affected platforms: Ubuntu 24, Windows 11, macOS 26
• Unaffected platforms: none

Preconditions

• split view enabled
• vertical tabs enabled
• sidebar is collapsed

Steps to reproduce

1. Create a Split View and in one view log in to Gmail.
2. Send an email to the address from comment 1.

Expected result

• The notification dot is displayed.

Actual result

• The notification dot is not displayed if the tab is in a Split View.

Regression range

• New feature. Happens after bug 1986946 implementation.

Additional notes

• Attached a screen recording.

Comment 2

[Sarah Clements [:sclements]]

In horizontal tabs the notification dot is covered by the tab favicon.

Comment 3

[John Iweh]

I am interested the project, I I be assigned to the project?

Comment 4

[John Iweh]

I am interested in fixing the bug, Can I be assigned to it?

Comment 5

[Kelly Cochrane [:kcochrane]]

Yes, I'll assign it to you John

Comment 6

[japandi]

I investigated this bug and found the root cause. In tabbrowser.js, there is a check at line 8640 that reads if (!tabForEvent || tabForEvent.selected) which causes an early return before the attention attribute is ever set on the tab. The problem is that in Split View, the Gmail tab has selected="true" on it since it is actively displayed, so this check always bails out early and the notification dot never appears.

The fix involved two changes. First, in tabbrowser.js I updated the condition to skip the early return when the tab is inside a tab-split-view-wrapper, so that split view tabs can now correctly receive the attention attribute. Second, in tabs.css I added a new selector to ensure the notification dot is rendered for split view tabs even when they carry the selected attribute.

The dot is now showing correctly in the collapsed vertical sidebar for split view tabs. The exact pixel positioning of the dot relative to the favicon may need a small follow-up tweak, but the core bug is fixed.

https://phabricator.services.mozilla.com/D289684

Comment 7

[japandi]

Attachment: Bug 1997925 - Show notification dot for tabs in Split View r=sthompson

Comment 8

[japandi]

Assign this to me. here is my patch https://phabricator.services.mozilla.com/D289684

Comment 9

[John Iweh]

Attachment: Bug 1997925 - fixed notification dot to show on tabs split view

Comment 10

[John Iweh]

I did fix the the bug of not showing the notification dot. here is my patch https://phabricator.services.mozilla.com/D289747

Comment 11

[Kelly Cochrane [:kcochrane]]

:japandi, this bug was already assigned to John. Please abandon any related revisions and keep an eye out for any new bugs we share in the Sidebar matrix channel.

Comment 12

[John Iweh]

I made an update to the patch, please review it https://phabricator.services.mozilla.com/D289747

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99d778090c0f
https://hg.mozilla.org/integration/autoland/rev/321af3942875
fixed notification dot to show on tabs split view r=desktop-theme-reviewers,tabbrowser-reviewers,nsharpley,kcochrane

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/321af3942875