1997929 - Save full page and Save visible buttons are displayed on the right view when the screenshot option is used on the left view

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 146.0a1 (2025-11-02)

Affected versions

• 146.0a1 (2025-11-02)

Tested platforms

• Affected platforms: Ubuntu 24, Windows 11, macOS 26
• Unaffected platforms: none

Preconditions

• split view enabled
• vertical tabs enabled
• sidebar is collapsed

Steps to reproduce

1. Create a Split View and use the Screenshot option on the left view.

Expected result

• The Save full page and the Save visible buttons are displayed on the left view.

Actual result

• The Save full page and the Save visible buttons are displayed on the right view.

Regression range

• New feature. Happens after bug 1986946 implementation.

Additional notes

• Attached a screenshot.

Comment 1

[Sam Foster [:sfoster] (he/him)]

• The screenshots module clones a template and inserts it into #tabbrowser-tabbox.
• We give style to the insertion point and container for the panel contents
• The buttons are positioned and styled relative to their container in screenshots-buttons.css

The same panel is reused for each tab, and is just shown/hidden as needed. So I guess we'll need to also adjust its position for the selected tab panel when we initially open it, and if a tab becomes part of a splitview - we'll need to listen for an event to respond to that.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1997929 - Move the Screenshots buttons panel into the browser's container when showing it. r?niklas!

• Clone the screenshots buttons panel template and insert into the tabpanel (deck-child).
• Stash a reference in the browserScreenshotsState weakmap for quick retrieval
• But also querySelector it from the tabpanels ancestor before giving up and making a new one
• Always move the panel before showing it
• Refactor ScreenshotsButtons to allow it to be move, recreated and reused.
• Add a test for the splitview case

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e43c9a0ee39
https://hg.mozilla.org/integration/autoland/rev/d599928494f8
Move the Screenshots buttons panel into the browser's container when showing it. r=niklas,desktop-theme-reviewers,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81bbeba53645
https://hg.mozilla.org/integration/autoland/rev/3e04f487a023
Revert "Bug 1997929 - Move the Screenshots buttons panel into the browser's container when showing it. r=niklas,desktop-theme-reviewers,dao" for causing bc failures @DOMLocalization.cpp.

Comment 5

[agoloman]

Backed out for causing bc failures @DOMLocalization.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure Log @browser_test_moving_tab_to_new_window.js

Comment 6

[Sam Foster [:sfoster] (he/him)]

(In reply to agoloman from comment #5)

Backed out for causing bc failures @DOMLocalization.cpp.

Thanks. I think I figured it out (as well as another intermittent.) Its queued to land again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bc492b3012a4
https://hg.mozilla.org/integration/autoland/rev/0a5f990b57a7
Move the Screenshots buttons panel into the browser's container when showing it. r=niklas,desktop-theme-reviewers,dao

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0a5f990b57a7

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! The issue is verified fixed with Firefox 149.0a1 (2026-01-28 on Windows 11, macOS 26 and Ubuntu 24. The Screenshot buttons are now displayed inside the active view, and they are working as expected. Note that we encountered bug 2013290 when testing this, but it's not dependent on this issue.