Closed Bug 1998628 Opened 4 months ago Closed 4 months ago

Release custom review prompt by default, keep the flag to control triggers/criteria

Categories

(Firefox for Android :: Experimentation and Telemetry, task)

Product:
Firefox for Android
Component:
Experimentation and Telemetry
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
147 Branch
Tracking Flags:
Tracking Status
firefox145 --- fixed
firefox146 --- fixed
firefox147 --- fixed

People

(Reporter: mkozinski, Assigned: mkozinski)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group2])

Attachments

(9 files)

Bug 1998628 - Part 2: Refactor ReviewPromptMiddleware to separate triggers from prompt type
48 bytes, text/x-phabricator-request
Details | Review
Bug 1998628 - Part 3: Enable custom prompt by default, keep the flag to control only criteria
48 bytes, text/x-phabricator-request
Details | Review
Bug 1998628 - Part 1: Add tests for review prompt feature flag and legacy criteria
48 bytes, text/x-phabricator-request
Details | Review
Bug 1998628 - Part 1: Add tests for review prompt feature flag and legacy criteria
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1998628 - Part 2: Refactor ReviewPromptMiddleware to separate triggers from prompt type
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1998628 - Part 3: Enable custom prompt by default, keep the flag to control only criteria
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1998628 - Part 1: Add tests for review prompt feature flag and legacy criteria
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review
Bug 1998628 - Part 2: Refactor ReviewPromptMiddleware to separate triggers from prompt type
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review
Bug 1998628 - Part 3: Enable custom prompt by default, keep the flag to control only criteria
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review

When we shut down the rollout we reverted the triggers to the old ones, but also stopped showing the custom UI. Andy agrees it makes sense to make the two independent and release the custom prompt UI by default already.

Attachment #9524998 - Attachment description: Bug 1998628 - Part 1: Refactor ReviewPromptMiddleware to separate triggers from prompt type → Bug 1998628 - Part 2: Refactor ReviewPromptMiddleware to separate triggers from prompt type
Attachment #9524999 - Attachment description: Bug 1998628 - Part 2: Enable custom prompt by default, keep the flag to control only criteria → Bug 1998628 - Part 3: Enable custom prompt by default, keep the flag to control only criteria
Pushed by mkozinski@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3c9266b72d15 https://hg.mozilla.org/integration/autoland/rev/e93bd4d0a187 Part 1: Add tests for review prompt feature flag and legacy criteria r=android-reviewers,gmalekpour https://github.com/mozilla-firefox/firefox/commit/ba6019b1c2cb https://hg.mozilla.org/integration/autoland/rev/86be457c09ab Part 2: Refactor ReviewPromptMiddleware to separate triggers from prompt type r=android-reviewers,twhite https://github.com/mozilla-firefox/firefox/commit/e6e6512ca523 https://hg.mozilla.org/integration/autoland/rev/29ecaca3490a Part 3: Enable custom prompt by default, keep the flag to control only criteria r=android-reviewers,twhite

https://hg.mozilla.org/mozilla-central/rev/e93bd4d0a187
https://hg.mozilla.org/mozilla-central/rev/86be457c09ab
https://hg.mozilla.org/mozilla-central/rev/29ecaca3490a

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox147: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
Attachment #9526424 - Flags: approval-mozilla-beta?
Attachment #9526425 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: We will continue to receive lower average ratings.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: This feature has been in release since 142. This small behaviour change enables it in an additional scenario.
  • String changes made/needed: no
  • Is Android affected?: yes
Attachment #9526426 - Flags: approval-mozilla-beta?
Attachment #9526424 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9526425 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9526426 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9527125 - Flags: approval-mozilla-release?
Attachment #9527126 - Flags: approval-mozilla-release?
Attachment #9527128 - Flags: approval-mozilla-release?

firefox-release Uplift Approval Request

  • User impact if declined: We will continue to receive lower average ratings.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: This feature has been in release since 142. This small behaviour change enables it in an additional scenario. Nightly and Beta 3 show no signs of any issues related to this change.
  • String changes made/needed: no
  • Is Android affected?: yes
Attachment #9527125 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9527126 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9527128 - Flags: approval-mozilla-release? → approval-mozilla-release+
Regressions: 2001801
Blocks: review-prompt-followups
No longer depends on: review-prompt-followups
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: