2001801 - Custom review prompt being displayed repeatedly in 145.0.1

Status: NEW

(Firefox for Android :: Onboarding, defect, P2)

Description

[twhite]

Original Reddit post of behaviour.

It appears the triggers aren't being respected OR the prompt recording is failing somehow. Not seeing any reports in Bugzilla so far or any other Reddit posts. Please link here if you see any.

Possible regression caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1998628.

Comment 1

[twhite]

Attachment: WIP: Bug 2001801 - Don't process showing the review if the user is not eligible in handleReviewPromptCheck.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1998628

:mkozinski, since you are the author of the regressor, bug 1998628, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox145 (release), tracked for firefox146 (beta) and tracked for firefox147 (nightly). We have limited time to fix this, the soft freeze is in 10 days. However, the bug still isn't assigned.

:mavduevskiy, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 4

[Pascal Chevrel:pascalc]

Wontfix for 145 as we ship our last dot release tomorrow

Comment 5

[twhite]

At this time, the issue appears to be isolated, with reports limited to the Reddit OP
and one additional commenter. The OP noted that enabling the Debug menu resolved the problem, though there is no clear technical rationale for why that would have an impact.

QA (Mira) was not able to reproduce this on several devices:

Pixel 6 (Android 16), Samsung Galaxy S22 Ultra (Android 16), and Xiaomi Redmi Note 8 (Android 11).

No related Bugzilla reports were found during investigation.

Comment 6

[twhite]

We will observe for any issues related to this until 146 ships on December 9th.

Comment 7

[Marcin Koziński]

Aaron Train brought a new report to our attention:
https://www.reddit.com/r/firefox/comments/1p9qbnq/feedback_popup_every_time_i_open_a_new_tab/