1998716 - Fix ESLint jsdoc/valid-types issues (due to 60.8.0 upgrade) in remote/shared/

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Mark Banner (:standard8)]

The 60.8.0 upgrade of eslint-plugin-jsdoc raised some new issues in the JSDoc for remote/shared.

Please can the team take a look at resolving these.

These files are currently disabled from jsdoc/valid-types in the rollouts file.

remote/shared/AppInfo.sys.mjs
  14:1  error  Syntax error in name: RemoteAgent.AppInfo  jsdoc/valid-types (eslint)

remote/shared/NavigationManager.sys.mjs
  958:1  error  Syntax error in namepath: navigation-started  jsdoc/valid-types (eslint)
  964:1  error  Syntax error in namepath: navigation-stopped  jsdoc/valid-types (eslint)

remote/shared/UserContextManager.sys.mjs
  28:1  error  Syntax error in namepath: user-context-created  jsdoc/valid-types (eslint)
  31:1  error  Syntax error in namepath: user-context-deleted  jsdoc/valid-types (eslint)

remote/shared/listeners/CachedResourceListener.sys.mjs
  34:1  error  Syntax error in namepath: cached-resource-sent  jsdoc/valid-types (eslint)

remote/shared/listeners/DataChannelListener.sys.mjs
  34:1  error  Syntax error in namepath: cached-resource-sent  jsdoc/valid-types (eslint)

remote/shared/listeners/DownloadListener.sys.mjs
  28:1  error  Syntax error in namepath: download-started  jsdoc/valid-types (eslint)

remote/shared/listeners/NetworkListener.sys.mjs
  32:1  error  Syntax error in namepath: before-request-sent  jsdoc/valid-types (eslint)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Is this somewhat blocking or need it to be done soon? We will discuss it in our next triage meeting.

Comment 2

[Mark Banner (:standard8)]

It isn't blocking, but it would be nice for it not to sit in the backlog for a long time.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1998716 - [remote] Fix jsdoc/valid-types issues in remote

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/18713a402b5a
https://hg.mozilla.org/integration/autoland/rev/1efdc3046108
[remote] Fix jsdoc/valid-types issues in remote r=frontend-codestyle-reviewers,Sasha

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1efdc3046108