1998747 - Contrast insufficient for account hub banner notifications in dark mode

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Martin Giger [:freaktechnik]]

The text color of the error banner does not have enough contrast in dark mode. It's supposed to be --color-text-base-dark, but instead it is --color-critical-pressed-dark. The color is correct for the light theme, so the text color should probably be updated to light-dark(var(--color-critical-pressed-light), var(--color-text-base-dark)).

Code: https://searchfox.org/comm-central/rev/5460c0728bdcf885644185f2d00768b6d4e2e7bf/mail/themes/shared/mail/accountHubForms.css#445
Figma: https://www.figma.com/design/1wGTkoIgRfyEbLeiW1XeIx/Design-System--%3E-Components?node-id=2898-2380&t=u1wjlHZofD73J0vT-4

Comment 1

[Alex Schmitz]

This is happening on the regular messages as well not just error

Comment 2

[Martin Giger [:freaktechnik]]

I think the other messages are using the correct colors as specified in figma though. But it wouldn't hurt to double check.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1998747 - Fix account hub notification text colors in dark mode. r=#thunderbird-front-end-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e183de6832fa
Fix account hub notification text colors in dark mode. r=aleca,rtaylor