1998748 - Add link as a shortcut for Japan

Status: VERIFIED FIXED

(Firefox for Android :: Top Sites, task)

Description

[Devota Aabel [:devota]]

See Jira for AC

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

From https://mozilla-hub.atlassian.net/browse/FXDROID-6353:

Acceptance criteria:

The following shortcut appears in the list of default suggested sites for the ja_JP locale

Link:: https://blog.mozilla.org/ja/firefox-ja/android-guide/

Title: Firefoxガイド

Favicon: Attached

Position in shortcuts order: First default suggested site

This should be behind a feature flag

Also, while we’re here, switch around the Amelbo and Yahoo shortcuts (Yahoo should be first)

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1998748 - Add link as a shortcut for Japan

Co-authored-by: Titouan Thibaud <[e-mail]>

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/007eaddbe00b
https://hg.mozilla.org/integration/autoland/rev/f7e58aa4dd20
Add link as a shortcut for Japan r=android-reviewers,tthibaud

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f7e58aa4dd20

Comment 5

[Adina Petridean QA [:apetridean]]

Hello @devota,
Could you please provide more information on how we should test this?
Is there anything we need to enable in the secret settings or any experiment we should activate in Nimbus?

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1998748 - Add link as a shortcut for Japan

Co-authored-by: Titouan Thibaud <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D272306

Comment 7

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: This is required by Product for the Japan MSCA efforts https://mozilla-hub.atlassian.net/browse/FXMO-680. We are adding default top sites that are region specific for the JP region.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: - Use VPN to set location to Japan
• Observe the default top sites that are added on a first launch onboarding experience matches the list of default top sites for Japan.
• Risk associated with taking this patch: medium
• Explanation of risk level: This is Medium risk because we haven't had manual QE verification. However, we are confident in the changes due to the level of automated test coverage and manual testing between author and reviewer.
• String changes made/needed: None
• Is Android affected?: yes

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/41004fe9341a
https://hg.mozilla.org/releases/mozilla-release/rev/c2be6fbef11d

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 10

[Pascal Chevrel:pascalc]

Gabriel, given the timing with the Android dot release that ships tomorrow, I took your uplifts into the release branch, but this should have been uplifted to beta first. There are no beta uplifts, that means that when 146 ships, the changes in 147 and now 145 will not be in 146.

I am tracking for 146 as we don't want to regress in December. Thanks!

Comment 11

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_20251118_101927_Firefox.jpg

Verified as fixed on Nightly 147.0a1 and RC 145.0.1 with Samsung Galaxy S23 Ultra (Android 14) and Moto G72 (Android 13).

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9526813 [details]
Bug 1998748 - Add link as a shortcut for Japan

Approved for 146.0b5

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ccda4e8e3d57
https://hg.mozilla.org/releases/mozilla-beta/rev/d13375cbba99

Comment 14

[Dianna Smith [:diannaS]]

adding qa verify flag back because this just landed in 146

Comment 15

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_20251120-102121.png

Verified as fixed on Fenix 146.05 with Samsung Galaxy S23 Ultra (Android 14) and Moto G72 (Android 13).