2002583 - Sponsored Top Sites are missing their logos (except for ones in tippy-top)

Status: VERIFIED FIXED

(Firefox for Android :: Top Sites, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce

1. Launch Firefox Nightly
2. Look at the sponsored top-site tiles on the new tab page (in the "Shortcuts" section)

Expected behavior

The tile should have the sponsor's brand-logo (e.g. a starburst for Walmart, the "chewy" wordmark for Chewy)

Actual behavior

The tile has a fallback initial-letter (e.g. a "W" for Walmart, and a "C" for Chewy)

Device information

• Firefox version: 147.0a1
• Android device model: Pixel 6a
• Android OS version: 16

Any additional information?

• This affects current beta and release as well.
• Regression range on Nightly: last-good build is 2025-11-12, first-bad build is 2025-11-13
• Those^ two factors suggest that this is a regression from bug 1998748.

Comment 1

[Daniel Holbert [:dholbert]]

(in my case the sponsored tile for Amazon does have its logo; but I think that's because we've got that one baked in via the "tippy-top" list)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug (note the "C" for Chewy)

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)

• Those^ two factors suggest that this is a regression from bug 1998748.

Credit to @dmueller for bringing up this bug's patch (in a slack discussion) as a candidate regression. He observed:
"Looks like this change stopped using the imageUrl from the sponsored tiles, if I'm reading the code correctly.
https://github.com/mozilla-firefox/firefox/commit/007eaddbe00b09a792be8bb3c6b0a9b610021e09#diff-47ad1082c483e6f8766ce1c9f6a8a4c30934259601cc331e812f4a543ef8943b
My interpretation as a first glance at the code is sponsored tiles are Topsite.Provided, and there was a check for that type which would use Topsite.Provided.imageUrl in the call to Favicon but it no longer does.

[EDIT] But Petru observes that there may be some additional nuance beyond that.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:gl, since you are the author of the regressor, bug 1998748, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

I've debugged this in code following a scenario I can reproduce also - missing a "real" favicon for the temu sponsored top site.
Saw that we are using the values we get from Mars but indeed using the url of the sponsored top site here and not the image url.
But tested that even after hardcoding the actual image url to be used our functionality for downloading favicons still could not download a valid one and will return a generated favicon with the first letter from the url hostname.

We already have many other bugs filed for problems with downloading favicons here so this bug seems like it relates to a bigger & older problem.

Comment 6

[daniel mueller]

(In reply to Petru-Mugurel Lingurar [:petru] from comment #5)

I've debugged this in code following a scenario I can reproduce also - missing a "real" favicon for the temu sponsored top site.
Saw that we are using the values we get from Mars but indeed using the url of the sponsored top site here and not the image url.
But tested that even after hardcoding the actual image url to be used our functionality for downloading favicons still could not download a valid one and will return a generated favicon with the first letter from the url hostname.

We already have many other bugs filed for problems with downloading favicons here so this bug seems like it relates to a bigger & older problem.

This is not related to a bigger and older problem. In the changeset I linked, specifically this block of code was removed so we stopped passing in the imageUrl field from the sponsored tile to create a favicon. Previously we would pass in both a parameter for url & imageUrl for sponsored tiles, now we are only passing in a parameter for url.

                if (topSite is TopSite.Provided) {
                    TopSiteFavicon(url = topSite.url, imageUrl = topSite.imageUrl)
                } else {
                    TopSiteFavicon(url = topSite.url, imageUrl = getImageUrl(url = topSite.url))
                }

In this code, if the topsite was sponsored (TopSite.Provided) then we pass in topSite.imageUrl. This was removed and now we're always trying to find an icon from the url.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2002583 - Use imageUrl for Sponsored Top Sites when loading TopSiteFavicon

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45b7b43ae67d
https://hg.mozilla.org/integration/autoland/rev/4af1533e614d
Use imageUrl for Sponsored Top Sites when loading TopSiteFavicon r=android-reviewers,Roger

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2002583 - Use imageUrl for Sponsored Top Sites when loading TopSiteFavicon

Original Revision: https://phabricator.services.mozilla.com/D274381

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: No favicon shown for Sponsored Top Sites
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: - Verify that sponsored top sites favicon are shown
• Risk associated with taking this patch: low
• Explanation of risk level: Low risk because it is only UI changes to utilize the image URL provided by sponsored top sites
• String changes made/needed: None
• Is Android affected?: yes

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4af1533e614d

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/da0ce9f5ccf1
https://hg.mozilla.org/releases/mozilla-beta/rev/347750c51058

Comment 13

[Daniel Holbert [:dholbert]]

Verified fixed in latest Nightly (2025-11-29T21:29:03). I see the correct logo for the Walmart top site.

Comment 14

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_2025-12-02-12-36-29-234_org.mozilla.firefox.jpg

Comment 15

[Adina Petridean QA [:apetridean]]

Verified fixed in latest Nightly 147.0a1 and RC 146.0 using Poco M4 Pro (Android 12) and Samsung Galaxy S24 (Android 15).
Please note that it is not fixed on Fenix 146.0b9.