1999693 - Support "ignore" for "unhandledPromptBehavior" for file pickers

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

In Bug 1855045, as we need to support file prompt events, we will initially dismiss all file picker prompts by default.
Otherwise such prompts are fully OS dependent and can completely block tests.

But normally, we should respect the configured unhandledPromptBehavior, and if the behavior is set to "ignore" for "file" prompts, then the prompt should not be dismissed automatically.

Comment 1

[Julian Descottes [:jdescottes]]

Let's not worry about enabling the tests on CI for now because we can't really handle the real file pickers in automation once they are open. We should still try to support the ignore behavior in case non-test-automation users are interested in this.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There is a regression with dismissing file pickers by default, and Julian fixed it with a workaround patch for now over on bug 2005673. Nevertheless we should give this bug a priority and correctly fix it in the next milestone.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1999693 - [bidi] Only dismiss filepickers for BiDi sessions with behavior != ignore

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1999693 - [wdspec] Dismiss file dialogs in file_dialog_opened.py to avoid windows CI crashes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f6b70ea8acc
https://hg.mozilla.org/integration/autoland/rev/65e1a66ab8fa
[bidi] Only dismiss filepickers for BiDi sessions with behavior != ignore r=Sasha
https://github.com/mozilla-firefox/firefox/commit/603f1f788db2
https://hg.mozilla.org/integration/autoland/rev/d7960dd6c909
[wdspec] Dismiss file dialogs in file_dialog_opened.py to avoid windows CI crashes r=Sasha

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/65e1a66ab8fa
https://hg.mozilla.org/mozilla-central/rev/d7960dd6c909

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60819 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot