Closed Bug 2000002 Opened 5 months ago Closed 3 months ago

Implement an edge-to-edge wallpaper

Categories

(Firefox for Android :: Homepage, task)

All
Android
task

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- verified

People

(Reporter: devota, Assigned: titouan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group5])

Attachments

(4 files, 2 obsolete files)

The desire is for the wallpaper (or a singular color if it's easier) to go "edge-to-edge", meaning behind the toolbar, and behind the system status bar and navigation bar if possible. Here is a bug that involved making the wallpaper go behind the toolbar for search in the middle.

Whiteboard: [fxdroid][group5]
Assignee: nobody → tthibaud
Status: NEW → ASSIGNED
Attachment #9527205 - Attachment description: WIP: Bug 2000002 - WIP - Set an edge to edge background on Homepage → Bug 2000002 - WIP - Set an edge to edge background on Homepage
Attachment #9527205 - Attachment description: Bug 2000002 - WIP - Set an edge to edge background on Homepage → Bug 2000002 - Set an edge to edge background on Homepage
Attachment #9531877 - Attachment is obsolete: true
Summary: [Spike] investigate options for an edge-to-edge wallpaper → Implement an edge-to-edge wallpaper

Hey,
I'll land the patch for this bug soon and it requires some QA testing to make sure everything is working correctly.
I'll try to describe as well as possible the process to test it, feel free to ask if you need any more information.

STR

  • Install the nightly apk from here (or Nightly after the patch has landed)
  • Open Settings > Homepage > Wallpapers
  • Select the first option

This will enable the Edge to Edge background, that will adapt to Dark/Light theme.

Things to test

There are a number of branches to test:

  • Toolbar on the top
  • Toolbar on the bottom
  • Tab strip
  • Private mode on the aforementioned cases

Figma

Here is the Figma link to show what was expected

Feel free to ask if anything is unclear.

Thanks a lot!

Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

Verified the listed scenarios on the above build.
The colors differ from those shown in the Figma designs.
@devota, could you please confirm whether in these screenshots are the expected colors, and not the ones from Figma? Please note that when the toolbar is set to the bottom, there is an additional darker orange color around the toolbar compared to the rest of the page.

Blocks: 2014189

Thanks a lot for the review Adina!

I realize the Figma was not totally clear. So the design showing the TabStrip is actually the one we had to implement for "No TabStrip" too.

Which explains the difference you're seeing.

With that information, does it look good? 

Feel free to need-info me in case anything is unclear.

Flags: needinfo?(apetridean)

Additionally, on the homepage tab strip there shouldn’t be any tab highlighted. Tabs are only highlighted when the user is on a webpage, to indicate the active tab. This matches the old behavior, so the current behavior is correct, not the one shown in Figma.
In all other aspects, everything looks good.
Verified on Google Pixel 10 (Android 16), SamsungTab S8 Ultra 5G (Android 15) and Samsung Galaxy S9 (Android 8).
CC @Titouan

Flags: needinfo?(apetridean)
Flags: needinfo?(tthibaud)
Flags: needinfo?(tthibaud)
Flags: needinfo?(tthibaud)

Thanks a lot for your review Adina!

Flags: needinfo?(tthibaud)

Comment on attachment 9540752 [details]
Bug 2000002 - Remove edge to edge background feature flag.

Revision D280841 was moved to bug 2014189. Setting attachment 9540752 [details] to obsolete.

Attachment #9540752 - Attachment is obsolete: true
See Also: → 2036680
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: