2000343 - moz-radio-group reacts to keypress when focus is not on a child moz-radio

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Mark Striemer [:mstriemer]]

The contrast controls in about:preferences have a radio group with a nested button in one of the radios. Focusing that button and pressing up or down will change the value of the parent radio group, but it shouldn't.

With the patch from bug 1972360 applied:

1. Focus the Color contrast radio group
2. Press down to select "Custom"
3. Press tab to focus Manage Colors... button
4. Press up

Expected results: The page scrolls a little
Actual results: To Color contrast setting changes to Off

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 2000343 - Ignore keypress from nested children in SelectControlBaseElement r?#recomp-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7cce9daae246
https://hg.mozilla.org/integration/autoland/rev/69d26099d537
Ignore keypress from nested children in SelectControlBaseElement r=hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/11d4b58923f0
https://hg.mozilla.org/integration/autoland/rev/b0cebcbaad1c
Revert "Bug 2000343, Bug 1972360, Bug 1972367 - Ignore keypress from nested children in SelectControlBaseElement r=hjones" for causing chrome failures in test_moz_fieldset.html

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing chrome failures in test_moz_fieldset.html

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ca7dd83ec77
https://hg.mozilla.org/integration/autoland/rev/f5ec1611de32
Ignore keypress from nested children in SelectControlBaseElement r=hjones

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f5ec1611de32