2000488 - Simplify logical axis conversion in orthogonal writing modes and self-alignment

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

I have ideas to clean up and simplify the code that handles logical axis conversions in orthogonal writing modes and self-alignment.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2000488 - Add a helper method to convert LogicalAxis from one writing mode to another. r?#layout

Converting a logical axis from one writing mode to another is a common operation
in layout. This helper improves readability.

This patch doesn't change behavior.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2000488 - Use nsStylePosition::UsedSelfAlignment() to simplify code. r?#layout

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2000488 - Remove AxisPolarityFlipped() in ReflowInput.cpp. r?#layout

AxisPolarityFlipped() returns the negation of
WritingMode::ParallelAxisStartsOnSameSide(). It is sufficient to keep one
implementation in WritingMode and port the shortcut in
ParallelAxisStartsOnSameSide().

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/62ad52e72505
https://hg.mozilla.org/integration/autoland/rev/7be8eadcb749
Add a helper method to convert LogicalAxis from one writing mode to another. r=layout-reviewers,jfkthame
https://github.com/mozilla-firefox/firefox/commit/a08fe7ba212e
https://hg.mozilla.org/integration/autoland/rev/36a6fbbc7ca1
Use nsStylePosition::UsedSelfAlignment() to simplify code. r=layout-reviewers,jfkthame
https://github.com/mozilla-firefox/firefox/commit/310a28289424
https://hg.mozilla.org/integration/autoland/rev/ee30037211b4
Remove AxisPolarityFlipped() in ReflowInput.cpp. r=layout-reviewers,jfkthame

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7be8eadcb749
https://hg.mozilla.org/mozilla-central/rev/36a6fbbc7ca1
https://hg.mozilla.org/mozilla-central/rev/ee30037211b4