2000759 - Improve helper methods that check masonry layout

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Per Jonathan's review comment in https://phabricator.services.mozilla.com/D272824#9439812, we can improve code readability handling orthogonal writing mode by creating an IsMasonry() that takes an writing-mode along with the axis. This bug implements that approach.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2000759 - Add IsMasonry overload that take a WritingMode parameter. r?jfkthame

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2000759 - Add two convenience methods IsColMasonry() and IsRowMasonry(). r?jfkthame

We have IsColSubgrid() and IsRowSubgrid(). Masonry layout should have
similar convenience helpers.

Move IsMasonry(LogicalAxis) from nsIFrame into nsGridContainerFrame for
two reasons:

1. There are no external callers, and having it in grid container frame remove the
   need to assert the caller is a grid container.
2. IsColSubgrid() and IsRowSubgrid() depend on it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/997c4612a979
https://hg.mozilla.org/integration/autoland/rev/a6efcce7a1d4
Add IsMasonry overload that take a WritingMode parameter. r=jfkthame,layout-reviewers
https://github.com/mozilla-firefox/firefox/commit/379011e6798b
https://hg.mozilla.org/integration/autoland/rev/89d80408fc1a
Add two convenience methods IsColMasonry() and IsRowMasonry(). r=jfkthame,layout-reviewers
https://github.com/mozilla-firefox/firefox/commit/78c24913e991
https://hg.mozilla.org/integration/autoland/rev/c76bbd98cea6
apply code formatting via Lando

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a6efcce7a1d4
https://hg.mozilla.org/mozilla-central/rev/89d80408fc1a
https://hg.mozilla.org/mozilla-central/rev/c76bbd98cea6