2000663 - Busted comm/mail/components/enterprisepolicies/tests/browser/browser_policy_handlers.js on Mac 14.70 all builds after bug 1998588 | single tracking bug

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: toby [at] thunderbird.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=535807128&repo=comm-central&task=G4GJKZgsQiarz3c952uMRQ.0
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/G4GJKZgsQiarz3c952uMRQ/runs/0/artifacts/public/logs/live_backing.log

---

After Bug 1998588 (“improve nsOSHelperAppService::OSProtocolHandlerExists on macOS”), Thunderbird’s macOS 14.7 browser-chrome tests began failing with an AppKit assertion:
`[NSWorkspace URLForApplicationToOpenURL:]: Assertion failed: url != nil`

Comment 1

[Toby Pilling [:tobyp]]

Hi Josh,
You may already be looking into this, but figured that I'd open this and ask your opinion on how we might get our Thunderbird tests passing again.

This issue seems to occur when Gecko calls OSProtocolHandlerExists() with an empty or invalid scheme and we end up passing a nil URL into URLForApplicationToOpenURL:.

Expected:
Return NS_ERROR_FAILURE when the scheme is invalid, without calling into NSWorkspace.

Suggested fix:
Add a nil/empty check before constructing or passing the NSURL.

Regression range:
First seen after Bug 1998588 (changeset 617c8e825899e09a36840474638488c5df15aae5).

Comment 2

[Josh Aas]

I'll try to fix this in the next few hours. I'm pretty sure I can get a patch put together based on the description of the problem here but I may not be able to run the comm-central tests myself (limited time). If someone can test the patch against comm-central that would be great.

Comment 3

[Toby Pilling [:tobyp]]

Nice, thanks so much!

Comment 4

[Josh Aas]

Attachment: Bug 2000663 - Properly handle invalid schemes in OSProtocolHandlerExists on macOS. r?spohl,tobyp

Comment 5

[Stephen A Pohl [:spohl]]

Setting n-i in case Phabricator didn't notify you of the review feedback.

Comment 6

[Josh Aas]

I'll push a fix as soon as phabricator is back up, I assume it's down because of the Cloudflare outage.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/848db37a75c1
https://hg.mozilla.org/integration/autoland/rev/d817380daf71
Properly handle invalid schemes in OSProtocolHandlerExists on macOS. r=spohl,tobyp

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d817380daf71

Comment 9

[Intermittent Failures Robot]

14 failures were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 13
• autoland: 1

Table

	no_variant	spi-nw
macosx1470-x86_64/debug	4
macosx1470-x86_64/opt	9
macosx1500-aarch64/opt		1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=2000663&startday=2025-11-17&endday=2025-11-23&tree=all