200067 - New folder should be created inside the current folder

Status: RESOLVED WONTFIX

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jan Varga [:janv]]

I believe it should also work for new separators this way.

Comment 1

[Pierre Chanial]

Insertion in the folder was the first implementation I've done in phoenix (bug
175404).
But doing so one could not insert between two folders and if insertion do not
occur where it's intended (instead: bottom of folder)
I think we should keep it as it is now, except for the bookmark root.
Thoughts?

Comment 2

[Pierre Chanial]

s/if insertion/insertion

Comment 3

[Jan Varga [:janv]]

what about adding a checkbox indicating if the user wants to create it inside
the current folder (checked by default) ?

Comment 4

[Pierre Chanial]

I think such a pref is not desiderable. We have to make a UI decision here.
We may do what ns4.x does here for paste:
- if the folder is closed: insert after it
- if open insert inside it at index=0
For the bookmark root: always insert at index=0

Such implementation has the advantage of always showing the pasted resources.

Note that inserting at index=0 or at the end as we currently do for DND is not
the problem here, but it's so related I could fix it at the same time.
(at the end paste and dnd should be consistent)

Comment 5

[Pierre Chanial]

s/=0/=1

Comment 6

[Jan Varga [:janv]]

ok, I like that approach, do you have time to implement it for 1.4 ?

Comment 7

[Pierre Chanial]

I'll send my thesis to the referees on wednesday. Then I'll have time to fix
that and the paste issue (I have no seamonkey tree atm)
I guess it will fit with the 1.4 schedule.

Comment 8

[Jan Varga [:janv]]

great, sounds good

Comment 9

[Chris Petersen]

*** Bug 203394 has been marked as a duplicate of this bug. ***

Comment 10

[Samir Gehani]

adt: nsbeta1-

Comment 11

[Pierre Chanial]

After giving some thoughts, I think that inserting resources at the beginning
instead of appending them is a UI change that may irritate users.
Jag, as xpfe owner, you're the one that has to decide.

I attach a fix to the issues that are somewhat independent in bug 210196.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If I open the context menu over a free area and select "New folder" the new
folder should be appended at the end of the list - like it's now working.
Instead creating a new folder by first selecting a folder in the folder pane the
new one has to be added as a subfolder. It's a behavior which occurs in almost
all applications. Additional it's really annoying to move the new folder
manually to a subfolder afterwards.

Comment 13

[Ray Booysen]

Reassigning as per Bug #32644

Comment 14

[:Hb]

Current behaviour is fine. WONTFIX