2000792 - www.bilibili.com - "Copy Clean Link" does not work

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Description

[Calin Tanase]

Environment:
Operating system: Windows 10
Firefox version: Firefox 145.0/147

Steps to reproduce:

1. Go to https://www.bilibili.com/
2. Right click on a video.
3. Select "Copy Clean Link" from the menu.

Expected Behavior:
The "Copy Clean Link" option can be selected and it works.

Actual Behavior:
The "Copy Clean Link" option is grayed.

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/189383

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 2

[Manuel Bucher [:manuel]]

https://www.bilibili.com/video/BV1TgCtBaEwS/?spm_id_from=333.1387.homepage.video_card.click
https://space.bilibili.com/12434430?spm_id_from=333.788.upinfo.detail.click
https://live.bilibili.com/544765?broadcast_type=0&is_room_feed=0&spm_id_from=333.1387.to_liveroom.0.click&live_from=86002

Query parameters to strip: spm_id_from, broadcast_type, is_room_feed, live_from

See Bug 1920601 comment 0 on how to write a patch.

Comment 3

[Manuel Bucher [:manuel]]

For the person submitting a patch: It would be good if you click a bit around on the website and look for further paramters to strip.

Comment 4

[Areeba]

I'm interested in working on this bug.

Comment 5

[Manuel Bucher [:manuel]]

That would be much apprechiated! I'll assign you to reflect that. Feel free to ping me on matrix in #introduction:mozilla.org or reach out directly on bugzilla if you have any questions.

Comment 6

[Areeba]

Hi Manuel, I submitted a patch on Phabricator. Please let me know if there anything else I can do. I looked around a website for a bit and couldn't find any other parameters.

Comment 7

[Areeba]

Attachment: Bug 2000792: Added tracking query parameters from bilibili to Copy Clean Link list r=manuel

Comment 8

[Manuel Bucher [:manuel]]

Thanks for doing so. Change looks good. I've left a review comment in phabricator: https://phabricator.services.mozilla.com/D274375#9492355

Comment 9

[Areeba]

Hi Manuel, I fixed the issues. Thanks for pointing it.

Comment 10

[Manuel Bucher [:manuel]]

Thanks for updating :). I initiated landing the patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3df1f643892a
https://hg.mozilla.org/integration/autoland/rev/317830e6cc2c
Added tracking query parameters from bilibili to Copy Clean Link list r=manuel

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/317830e6cc2c