Closed Bug 2000840 Opened 1 year ago Closed 6 months ago

[Wayland] Move mFrameCallback to VSync frame callback

Categories

(Core :: Widget: Gtk, task, P3)

task

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox152 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(6 external files, 1 obsolete file)

We use mFrameCallback for VSync only (and on toplevels only) so we may rename it to VSync to make clear what's used for.

Flags: needinfo?(stransky)

Rename to mVSyncCallback, for example?

Flags: needinfo?(stransky)
Summary: [Wayland] Rename mFrameCallback to VSync frame callback → [Wayland] Move mFrameCallback to VSync frame callback
Flags: needinfo?(stransky)
See Also: → 2010733
See Also: → 2012350

We should also check we have frame callback configured after potential unmap -> map sequence.

Blocks: 2022183

We'd need it for Bug 2022183 too.

We'd need to:

  • rename FrameCallback to VSyncFrameCallback to make it clear it's for VSync only
  • make VSyncFrameCallback persistent across map/unmap -> perhaps better conect WaylandSurface and VSyncSource
  • extract other callbacks from RequestFrameCallbackLocked()

The main change here is that we fire emulated vsync even on unmapped surfaces and let vsync source to enable/disable it.

Assignee: nobody → stransky
Attachment #9583922 - Attachment description: WIP: Bug 2000840 [Wayland] Rename FrameCallback to VSync callback and unify opaque frame callback → Bug 2000840 [Wayland] Rename FrameCallback to VSync callback and unify opaque frame callback r?emilio
Status: NEW → ASSIGNED
Attachment #9583924 - Attachment description: WIP: Bug 2000840 [Wayland] Rework vsync → Bug 2000840 [Wayland] Fire emulated VSync events for unmapped surfaces r?emilio
Attachment #9583240 - Attachment is obsolete: true
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a3b7fddd82b0 https://hg.mozilla.org/integration/autoland/rev/c96d4072bbac Revert "Bug 2000840 [Wayland][HDR] Run emulated VSync only if all layers are hidden r=emilio" for causing multiple failures.

Reverted this because it was causing multiple failures.

Flags: needinfo?(stransky)
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e43ecaa540e0 https://hg.mozilla.org/integration/autoland/rev/a25cd2e52a39 Revert "Bug 2000840 [Wayland][HDR] Run emulated VSync only if all layers are hidden r=emilio" for causing assertion failures @ WaylandSurface.cpp
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/363835901f61 https://hg.mozilla.org/integration/autoland/rev/dac651300190 Revert "Bug 2000840 [Wayland] Queue emulated VSync on main thread directly r=emilio" for causing assertion failures @ WaylandSurface.cpp

Nice to see we have Wayland test coverage now!

Flags: needinfo?(stransky)
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: