[Wayland] Move mFrameCallback to VSync frame callback
Categories
(Core :: Widget: Gtk, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(6 external files, 1 obsolete file)
We use mFrameCallback for VSync only (and on toplevels only) so we may rename it to VSync to make clear what's used for.
| Assignee | ||
Updated•1 year ago
|
Comment 1•1 year ago
|
||
Rename to mVSyncCallback, for example?
| Assignee | ||
Updated•11 months ago
|
| Assignee | ||
Updated•11 months ago
|
| Assignee | ||
Comment 2•9 months ago
|
||
We should also check we have frame callback configured after potential unmap -> map sequence.
| Assignee | ||
Comment 3•6 months ago
|
||
We'd need it for Bug 2022183 too.
| Assignee | ||
Comment 4•6 months ago
|
||
| Assignee | ||
Comment 5•6 months ago
|
||
We'd need to:
- rename FrameCallback to VSyncFrameCallback to make it clear it's for VSync only
- make VSyncFrameCallback persistent across map/unmap -> perhaps better conect WaylandSurface and VSyncSource
- extract other callbacks from RequestFrameCallbackLocked()
| Assignee | ||
Comment 6•6 months ago
|
||
| Assignee | ||
Comment 7•6 months ago
|
||
| Assignee | ||
Comment 8•6 months ago
|
||
The main change here is that we fire emulated vsync even on unmapped surfaces and let vsync source to enable/disable it.
Updated•6 months ago
|
Updated•6 months ago
|
| Assignee | ||
Comment 9•6 months ago
|
||
| Assignee | ||
Comment 10•6 months ago
|
||
Updated•6 months ago
|
Comment 11•6 months ago
|
||
Comment 12•6 months ago
|
||
Comment 13•6 months ago
•
|
||
Reverted this because it was causing multiple failures.
| Assignee | ||
Updated•6 months ago
|
Comment 14•6 months ago
|
||
Comment 15•6 months ago
|
||
Comment 16•6 months ago
|
||
Backed out for causing assertion failures @ WaylandSurface.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/a25cd2e52a39dd4a633ff9c364353bd7ce1497de
| Assignee | ||
Comment 17•6 months ago
|
||
Comment 18•6 months ago
|
||
Comment 19•6 months ago
|
||
Comment 20•6 months ago
|
||
Backed out for causing assertion failures @ WaylandSurface.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/dac6513001909b29f01e63caf6f60dd9e4677444
| Assignee | ||
Comment 21•6 months ago
|
||
Nice to see we have Wayland test coverage now!
| Assignee | ||
Comment 22•6 months ago
|
||
Comment 23•6 months ago
|
||
Comment 24•6 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fb346e40a521
https://hg.mozilla.org/mozilla-central/rev/dfe54c312e86
https://hg.mozilla.org/mozilla-central/rev/fbba7edff364
https://hg.mozilla.org/mozilla-central/rev/94cea2633559
https://hg.mozilla.org/mozilla-central/rev/9e08fe064b26
https://hg.mozilla.org/mozilla-central/rev/f6d826ee88bb
Updated•6 months ago
|
Description
•