[Wayland] Implement xx-session-management-v1
Categories
(Core :: Widget: Gtk, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 4 external files, 2 obsolete files)
| Assignee | ||
Comment 1•8 months ago
|
||
We may implement xx_ variant of the protocol as it's seems to be available in KDE/Mutter.
Comment 2•7 months ago
|
||
There is now an official xdg- variant decided upon and ACKed by KDE, GNOME and Chromium (and I guess implemented in those soon), see https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/18#note_3375004
| Assignee | ||
Comment 3•7 months ago
|
||
Cool. But we need to have them available in compositors to implement it. AFAIK Mutter 50 doesn't ship that yet, right?
Comment 4•7 months ago
|
||
No idea about Mutter, I followed that from the KDE side (as a user eager to have session restore supported under Wayland so I can finally switch to that), and the kwin bug https://bugs.kde.org/show_bug.cgi?id=436318 (which is hard to follow as it's tons of me-too messages) just mentioned the protocol link above and the kwin merge request at https://invent.kde.org/plasma/kwin/-/merge_requests/8985 which should make this available in Plasma 6.7 (expected in June). I hope Mutter is similarly quick to support this.
| Assignee | ||
Comment 5•7 months ago
|
||
Okay. The xx- variant is mentioned here as it may be available now.
| Assignee | ||
Comment 6•7 months ago
|
||
| Assignee | ||
Comment 7•7 months ago
|
||
The patch here depends on custom tweak gdk_wayland_window_get_xdg_toplevel(). I'll investigate how it works.
| Assignee | ||
Comment 8•7 months ago
|
||
| Assignee | ||
Comment 9•7 months ago
|
||
xx- protocol variant
| Assignee | ||
Comment 10•7 months ago
|
||
The main problem here is to get workspace/window ID before the toplevel is mapped. Looks like other platforms rather move window to workspace after it's shown and that's different on Wayland. I guess we have some options here:
- Postpone window shown after nsWindowWayland::MoveToWorkspace() call. That may be tricky as the nsWindowWayland::MoveToWorkspace() may not come (for new windows? If restore data is missing?)
- Get WorkspaceID somehow on our own before window map or add extra window flag which will be stored/saved?
| Assignee | ||
Comment 11•7 months ago
|
||
We can postpone the window show after restore but that needs fiddle with vsync - to fire painting events before the windows is shown to kick off rendering pipeline.
Another issue is that xdg_toplevel has to be added to restore state before first commit to wl_surface (wtf???). So we'd need to use a kind of gtk3 callback here.
| Assignee | ||
Comment 12•7 months ago
|
||
We need to put something like this to gtk3 to get xdg_toplevel before is committed.
| Assignee | ||
Updated•7 months ago
|
| Assignee | ||
Comment 13•7 months ago
|
||
Updated•7 months ago
|
| Assignee | ||
Comment 14•7 months ago
|
||
| Assignee | ||
Comment 15•7 months ago
|
||
| Assignee | ||
Comment 16•7 months ago
|
||
| Assignee | ||
Comment 17•7 months ago
|
||
Gtk3 counterpart is https://gitlab.gnome.org/GNOME/gtk/-/issues/8076
| Assignee | ||
Comment 18•6 months ago
|
||
Realized that it also needs VSync update to fire rendering when we're waiting to session restore.
Updated•6 months ago
|
Updated•6 months ago
|
| Assignee | ||
Updated•6 months ago
|
| Assignee | ||
Comment 19•6 months ago
|
||
Bug 2000840 may be continue of this one - we'd need to run sw vsync before first paint.
Comment 20•6 months ago
|
||
Comment 21•6 months ago
|
||
Comment 22•6 months ago
|
||
Backed out for causing build bustages on nsWindowWayland
| Assignee | ||
Updated•6 months ago
|
Comment 23•6 months ago
|
||
Comment 24•6 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0e867910fe40
https://hg.mozilla.org/mozilla-central/rev/b9f78e413309
https://hg.mozilla.org/mozilla-central/rev/f461010792c8
https://hg.mozilla.org/mozilla-central/rev/73dfcc07f2e7
Updated•6 months ago
|
Description
•