2000899 - New Message or Reply or Forward does not show the relevant icon of an attached file for attachments with a space in the name

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Anje]

Attachment: 146.0b2-attach icon.jpg

Windows 11 OS
Beta 146.0b2
Process

• Click on '+New Message' OR 'Reply' or 'Forward' an email
• Click on 'Attach'
• Select a document file of any type
• click on 'Open'

Actual Results
Before email is sent...
Attachment is added
File name is correct
The icon normally positioned before the attchment name is missing.

Expected REsult
Before email is sent...
Attachment is added
File name is correct
The icon normally positioned before the attchment name is visible.

The following is ok:
In 'Sent' of sending address and 'Inbox' folder of received email.

• Sent Email shows
• paperclip 1 attachment
• image icon name of file.jpg

Also reported in Support Forum by user on version 145.0
https://support.mozilla.org/en-US/questions/1547712

Comment 1

[Magnus Melin [:mkmelin] (away until July 8)]

I see an icon on linux. Perhaps Windows only.

Comment 2

[Ed]

For me with Beta 146.0b2, when replying the first attachment doesn't show the icon but subsequent attachments do. I don't have the problem with a new message or when forwarding.

Comment 3

[Magnus Melin [:mkmelin] (away until July 8)]

Anje, Ed: How is v147 or v148 beta?

Comment 4

[Ed]

(In reply to Magnus Melin [:mkmelin] from comment #3)

Anje, Ed: How is v147 or v148 beta?

Still not right in 147, but 148 looks good.

Comment 5

[Richard Marti (:Paenglab)]

I tested this on Daily and see it too but only on attachments with a space in the name like on Attachment 9527453 [details].

I tried the same on ESR (v140) there it works. The difference is that ESR uses src instead of srcset for the icon. I copied the srcset from Daily and inserted it in ESR and the icon was still shown. So something must have changed in the decoding of the srcset (or moz-icon?)as I see the :-moz-broken on this icon with Daily.

Comment 6

[Francesco]

Mozregression took me here:
https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=61954872dac42ed6c9ffede53c872f4a29f10ce2&tochange=605deddad76418c81983691828bd0ba2fc0f231d
So likely bug 1967908.

Comment 7

[Francesco]

The issue seems to be the format of the srcset attribute:

srcset="
moz-icon://a b.txt?size=16&contentType=null&scale=1 1x,
moz-icon://a b.txt?size=16&contentType=null&scale=2 2x,
moz-icon://a b.txt?size=16&contentType=null&scale=3 3x"

If I remove the space in a b.txt, it works. Maybe URL-encode the filename?

Comment 8

[Francesco]

Attachment: missing-icon.png

The issue is not only on the message attachments, it also happens elsewhere, like in the list of downloads.

Comment 9

[Max Emig [:maxe]]

(In reply to Francesco from comment #6)

Mozregression took me here:
https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=61954872dac42ed6c9ffede53c872f4a29f10ce2&tochange=605deddad76418c81983691828bd0ba2fc0f231d
So likely bug 1967908.

I think this is accurate.

Comment 10

[Max Emig [:maxe]]

We should really move the logic to a shared helper instead of duplicating it a bunch of times, by far not the only place potentially affected.

Comment 11

[Max Emig [:maxe]]

Attachment: Bug 2000899 - Ensure attachment icons for filenames with spaces render on Windows using a new shared helper. r=#thunderbird-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe142fe18806
Ensure attachment icons for filenames with spaces render on Windows using a new shared helper. r=mkmelin

Comment 13

[Francesco]

Thanks for fixing!