Closed
Bug 2001148
Opened 1 year ago
Closed 11 months ago
[toolbar redesign] Remove share in simple toolbar when tabstrip is enabled
Categories
(Firefox for Android :: Toolbar, task)
Tracking
()
VERIFIED
FIXED
147 Branch
| Tracking | Status | |
|---|---|---|
| firefox147 | --- | verified |
People
(Reporter: RJ, Assigned: moyin)
References
Details
(Whiteboard: [fxdroid][group3])
Attachments
(1 external file)
The customizable shortcut and tab counter buttons are now always visible regardless of tabstrip, so we should remove the extra share button. The extra share button is also available in TabPreview.
To see the share in simple toolbar, ensure toolbar redesign option is enabled in secret settings, tabstrip is enabled, and the orientation of the phone is in landscape.
| Reporter | ||
Updated•11 months ago
|
Whiteboard: [fxdroid][group3]
Updated•11 months ago
|
| Reporter | ||
Comment 1•11 months ago
•
|
||
To add more context: we moved the New Tab and Tabs Tray icons from the tab strip to the end of the browser actions. Since the Share icon is also positioned there, the toolbar has become cramped again.
| Assignee | ||
Updated•11 months ago
|
Assignee: nobody → madeyemi
| Assignee | ||
Updated•11 months ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•11 months ago
|
||
Pushed by madeyemi@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/98a7f035de8a
https://hg.mozilla.org/integration/autoland/rev/1d083dd7a3b0
Remove share in simple toolbar when tabstrip is enabled r=android-reviewers,RJ
Comment 4•11 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox147:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
Comment 5•11 months ago
|
||
Verified as fixed on the 147.0a1 from 11/27 with a Pixel 6 (Android 16), and a Xiaomi Redmi Note 8T (Andorid 11).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•