2001154 - Show newly redesigned File and Applications settings on new Downloads page when redesign is enabled

Status: NEW

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Downloads page will need to be converted to the config-based settings structure.

https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=12287-23125&m=dev

This page will have the following sections which may be good candidates for individual bugs to work on:

• Save files to (Downloads)
• Files and applications

Comment 1

[Hanna Jones [:hjones]]

Once all the blocking conversions are complete this bug will cover the work involved in reorganizing the relevant sections to create the finalized Downloads page as specified in Figma here: https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=12287-23125&m=dev

As part of this work we should also make sure all the strings and illustrations match the design.

Comment 2

[Mark Kennedy [:mark]]

Attachment: Bug 2001154 - Show redesigned Downloads settings on new pane r=#reusable-components-reviewers-rotation

Comment 3

[Mark Kennedy [:mark]]

Attachment: legacy design on General pane with pref OFF.png

Comment 4

[Mark Kennedy [:mark]]

Attachment: new design on Downloads page when redesign enabled.png

Comment 5

[Mark Kennedy [:mark]]

Notes for QA

1. When redesign is NOT enabled (browser-settings-redesign.enabled is not set), everything under "Files and Applications" section on General pane should display as it currently does.
2. When redesign is enabled (browser-settings-redesign.enabled is set to true):
   a. a new "Downloads" navigation item should appear on the sidebar
   b. clicking the "Downloads" sidebar item should open a new page that shows everything that was under "Files and Applications" under a new "Downloads" heading on the new Downloads page but their redesigned versions (shown in new design on Downloads page when redesign enabled.png screenshot)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cdc9a5c24279
https://hg.mozilla.org/integration/autoland/rev/0413fe980b47
Show redesigned Downloads settings on new pane r=fluent-reviewers,akulyk,bolsson

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a249a43995d7
https://hg.mozilla.org/integration/autoland/rev/4fa1acea0d82
Revert "Bug 2001154 - Show redesigned Downloads settings on new pane r=fluent-reviewers,akulyk,bolsson" for causing bc failures at browser_setting_group_in_progress.js

Comment 8

[rperta]

Backed out for causing bc failures at browser_setting_group_in_progress.js
Backout link
Push with failures
Failure log(s)