2001496 - Chat History View/Search

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, task, P1)

Comment 1

[mlucks]

Attachment: Bug 2001496 - Chat History in FXView - r?omarg

Comment 2

[Sarah Clements [:sclements]]

Hi, there aren't any details in the commit message or bug except to a link to a massive PRD which isn't very helpful - can you please add more context about this feature and changes to Firefox View in the bug and commit message?

Comment 3

[mlucks]

Responded to @sclements via slack

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/525f3639cd22
https://hg.mozilla.org/integration/autoland/rev/c094bf0d6a37
Chat History in FXView - r=omarg,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,ai-frontend-reviewers,sfoster,bolsson

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d7fbd8018f08
https://hg.mozilla.org/integration/autoland/rev/d1dedcac5358
Revert "Bug 2001496 - Chat History in FXView - r=omarg,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,ai-frontend-reviewers,sfoster,bolsson" for causing bc failures @ browser_exclude_fxview_hidden_tabs.js

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_exclude_fxview_hidden_tabs.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d1dedcac5358f2afbfb4a7aa0af6ac96330aa886

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_exclude_fxview_hidden_tabs.js

also these failures

https://treeherder.mozilla.org/logviewer?job_id=546131089&repo=autoland&task=T_KB5y2qQOWz9aqDu5m5Mw.0&lineNumber=2992

https://treeherder.mozilla.org/logviewer?job_id=546131005&repo=autoland&task=Ro7cGMZyRcG6SnFejfRSIQ.0&lineNumber=2910

Comment 7

[mlucks]

Thank you, I have addressed the errors, running a ./mach try to confirm.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72dd70d90a84
https://hg.mozilla.org/integration/autoland/rev/fcc86555ea6e
Chat History in FXView - r=omarg,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,ai-frontend-reviewers,sfoster,bolsson

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/515df1fa8b44
https://hg.mozilla.org/integration/autoland/rev/7591dc7ba138
Revert "Bug 2001496 - Chat History in FXView - r=omarg,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,ai-frontend-reviewers,sfoster,bolsson" for causing bc failures @ browser_firefoxview_navigation.js

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_firefoxview_navigation.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7591dc7ba1389ba223751cd7db6fac21744168d1

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_firefoxview_navigation.js

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bdbba19b6f21
https://hg.mozilla.org/integration/autoland/rev/42776b3c94e0
Chat History in FXView - r=omarg,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,ai-frontend-reviewers,sfoster,bolsson

Comment 12

[mlucks]

I have attempted to land this again, my try came through clean, however I did forget to rebase on main before trying to land again. LMK if it needs to get backed out again.

Comment 13

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/42776b3c94e0