200150 - Unable to display IDN URL in the attachment pane with Send Page

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Composition, defect)

Description

[marina]

seen with 2003033003 build on WinXP EN

to reproduce:
- Edit your prefs.js file with these lines:
user_pref("network.IDN_prefix", "bq--");
user_pref("network.IDN_testbed", true);
user_pref("network.enableIDN", true);

- go to File|Send page;
//note: the display of IDN is garbled, screen shot to follow

Comment 1

[marina]

Attachment: this is a screen shot of the IDN display in the attachment

Comment 2

[nhottanscp]

reassign to nhotta

Comment 3

[Samir Gehani]

i18n triage team: nsbeta1+/adt3

Comment 4

[Jungshik Shin]

We need to do something here
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#3611

Comment 5

[Jungshik Shin]

nsIMsgAttachment has a data member |string url|. Obviously, it can't handle an
URL whose hostname part is in UTF-8. 

Comment 6

[Darin Fisher]

Either change that |string| to |AUTF8String| or pass |nsIURI| or call
GetAsciiSpec and pass that through the |string| parameter.

Comment 7

[Jungshik Shin]

Attachment: an incomplete patch

I still need to fix nsUTF8ConverterService and/or nsSubTextURI. With this
incomplete fix, http://IDN.host.addres.tld works but if there's a path part in
non-UTF-8 charset, it wouldn't work.

Comment 8

[Jungshik Shin]

(In reply to comment #6)
> Either change that |string| to |AUTF8String| or pass |nsIURI| or call
> GetAsciiSpec and pass that through the |string| parameter.

Ooops. I didn't read this until I made a patch. Passing |nsIURI| may (or may not
) be the best. I'll think more about it. 

Comment 9

[Jungshik Shin]

bug 229548 and bug 240300 are related to this bug in that both have to call
nsSubTextURI

Comment 10

[Jungshik Shin]

sorry for spamming. 

s/nsSubTextURI/nsTextToSubURI or nsUTF8ConverterService/

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

+  if (Substring(scheme, 0, 5).EqualsASCII("http:"))


EqualsLiteral? or maybe even LowerCaseEqualsLiteral?

(personally I'd prefer passing nsIURI instead of a string, since that doesn't
loose the origin charset)

Comment 12

[Mike Cowperthwaite]

Adding a URL for testing.
(from: <http://www.w3.org/International/tests/sec-idn-1>)

With this URL in Seamonkey 1.5, on my Win2K/en-US installation, after Send Page, the attachment panel shows a blank name (the URL's first character is Chinese).  I had wondered if the IDN work done in early 2005 might have affected this bug, but I guess not.

I don't know whether the 'prefix' or 'testbed' preferences (comment 0) are still valid.

Comment 13

[Mark Banner (:standard8)]

This is a SeaMonkey only bug now (although parts may affect core). Firefox/Thunderbird integrated can Send Link and that works fine, they don't have Send Page afaik.

Comment 16

[Philip Chee]

WORKSFORME => Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1pre) Gecko/20110408 Firefox/4.0.1pre SeaMonkey/2.1pre

Tested with several example links from http://idn.icann.org/